[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): iPhone 15 Pro Max / iOS 18.2
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Workspace Settings

Action Performed:

1. Launch ND or hybrid app.
2. Go to workspace settings > More features.
3. Enable Workflows.

Expected Result:

There will be animation in workspace editor when app returns to workspace editor after enabling Workflows (production behavior).

Actual Result:

There is no animation in workspace editor when app returns to workspace editor after enabling Workflows.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6716777_1737126750484.ScreenRecording_01-17-2025_23-09-54_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

I can confirm the issue but not super clear to me yet what code added this

[AndrewGable]

The only thing I can see is these changes: #53938, but not really sure how they relate as it seems like the code that does this navigating and animation is not changed.

@thesahindia @mountiny @sumo-slonik - Would you mind checking to see if this PR introduced this?

[mountiny]

@thesahindia could you test a revert PR if this is coming from our PR? Thank you!

[mountiny]

Bumped in the slack thread too

[thesahindia]

Revert PR: #55451

[Beamanator]

Revert PR was CP'd, waiting on retest 🙏

[blazejkustra]

Me and @sumo-slonik are working on a fix 👀

[Beamanator]

Applause confirmed (here) this was fixed by the revert PR 👍 so removing blocker label

[blazejkustra]

Update: @sumo-slonik prepared a PR with a fix yesterday.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert 53938 #55451

If no regressions arise, payment will be issued on 2025-01-28. 🎊

[melvin-bot]

@AndrewGable @isabelastisser @AndrewGable The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[isabelastisser]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert 53938 #55451

If no regressions arise, payment will be issued on 2025-01-30. 🎊

[melvin-bot]

@AndrewGable @isabelastisser @AndrewGable The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@AndrewGable, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[isabelastisser]

@AndrewGable, do we need a regression test here?

[AndrewGable]

No I don't think so!

[isabelastisser]

Thanks for confirming! Closing this since no payment is needed.