[Due for payment 2025-02-13] [$250] Get started tooltip shown on multiple #admins room.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Login with new account
2. Choose to manage a team for purpose of onboarding flow
3. Create another workspace
4. Pin all admin rooms
5. Refresh the page

Expected Result:

Only one "get started" tooltip on the admin room

Actual Result:

Get started tooltip shown on multiple #admins room.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

More details in the OP post in the slack

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881474402423530233
• Upwork Job ID: 1881474402423530233
• Last Price Increase: 2025-01-20
• Automatic offers:
• DylanDylann | Reviewer | 105793171
• nkdengineer | Contributor | 105793175

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 17:27:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Get started tooltip shown on multiple #admins room.

What is the root cause of that problem?

If the onboarding is a guide assigned, we always show the get started tooltip for all admin reports.

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 65 in bc29231

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) : isConciergeChatReport(report);

What changes do you think we should make in order to solve the problem?

We should only show the get started tooltip for the admin report is the guide assigned admin room. We can get this admin room from account.adminsRoomReportID.

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) && report?.reportID === account?.adminsRoomReportID : isConciergeChatReport(report);

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 65 in bc29231

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) : isConciergeChatReport(report);

We need to call getAssignedSupportData API to get the support data. We can do this in SidebarLinks to prevent it's called many times.

useEffect(() => {
    if (!activePolicyID) {
        return;
    }
    getAssignedSupportData(activePolicyID);
}, [activePolicyID]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI issue so I don't think we need the test.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

I can reproduce this bug:

Steps:

1. Login with new account
2. Choose to manage a team for purpose of onboarding flow
3. Create another workspace
4. Pin all admin rooms
5. Refresh the page

Screen.Recording.2025-01-21.at.00.20.48.mov

[DylanDylann]

I should take over this bug as C+ as mentioned here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021881474402423530233

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

Sounds good! Assigned!

[DylanDylann]

We need to call getAssignedSupportData API to get the support data. We can do this in SidebarLinks to prevent it's called many times.

@nkdengineer Could you please explain this point? Why do we need to do that?

[nkdengineer]

@DylanDylann That because the account.adminsRoomReportID is only available after we call this API.

[DylanDylann]

@nkdengineer's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

Just found an easier way to detect the onboarding admin room, we can use the same method here that will use the onboarding data to detect this and we don't need to call the get support data.

App/src/pages/home/HeaderView.tsx

Line 191 in cfc4e49

const isChatUsedForOnboarding = isChatUsedForOnboardingReportUtils(report, onboardingPurposeSelected);

[marcochavezf]

Thanks for the review @DylanDylann, assigning @nkdengineer 🚀

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@marcochavezf, @jliexpensify, @DylanDylann, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Payment not due yet Melvin, chill

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Revert revert moving tasks to admins room for "Manage my team expenses" intent #53661 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Resize to a small screen if we're on Web/Desktop

Test:

1. Sign in a new account without +
2. In the onboarding flow, select Manage my team purpose
3. Complete the onboarding
4. Create another workspace
5. From the workspace list page, go to the admin room
6. Open admin room detail and pin it to LHN
7. Go back to LHN and verify that only onboarding admin room row shows the Get started tooltip

Do we agree 👍 or 👎

[jliexpensify]

Paid and job closed!

[flaviadefaria]

Hey team I just ran into this while reviewing a customer's session In FullStory, could it be related to this PR?

[nkdengineer]

@flaviadefaria Is the onboardingData of this user is empty object? In the image above, I also see two admin rooms showing the free trial banner.

[melvin-bot]

@marcochavezf @jliexpensify @DylanDylann @nkdengineer this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@marcochavezf, @jliexpensify, @DylanDylann, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Not overdue, waiting on @flaviadefaria to respond

[flaviadefaria]

@flaviadefaria Is the onboardingData of this user is empty object?

How can I check this?

@jliexpensify here is the Slack thread in case you can help out - https://expensify.slack.com/archives/C07NMDKEFMH/p1739558669018079

[nkdengineer]

How can I check this?

@flaviadefaria Can you get the onyx state of customer's session In FullStory? It's helpful to check what is the problem because we fixed the bug two Get started tooltip in this issue.

[melvin-bot]

@marcochavezf, @jliexpensify, @DylanDylann, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!