Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Tooltip - Two same tooltips appear in Reports page #56027

Closed
2 of 8 tasks
mitarachim opened this issue Jan 30, 2025 · 15 comments
Closed
2 of 8 tasks

Web - Tooltip - Two same tooltips appear in Reports page #56027

mitarachim opened this issue Jan 30, 2025 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Jan 30, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account.
  3. Open FAB to dismiss the tooltip.
  4. Close the tooltip.
  5. Go to Reports.
  6. Go to Inbox.
  7. Go to Reports.
  8. Go to Inbox.
  9. Go to Reports.

Expected Result:

Only one tooltip will appear in Reports page.

Actual Result:

Two same tooltips appear in Reports page - one under filter button, one at the top left of the page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6728136_1738206316670.20250130_110138.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 30, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 30, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@techievivek
Copy link
Contributor

@SzymczakJ Seems related to #55078? CC @syz

@IuliiaHerets
Copy link

@techievivek QA team faced with a similar issue: Second "Customize your search here" tooltip appears after applying filter by WS

Preconditions: User has a workspace and created some expenses on the workspace chat and 1:1 chat

  1. Log in to ND as gmail user
  2. Navigate to the Reports tab/ Expenses page
  3. Click on the workspace selector at the top left corner and select the workspace to filter out the expenses
Bug6728152_1738208458842.Recording__358.mp4

Should we export it as a new issue or is it a same root? Thanks

@SzymczakJ
Copy link
Contributor

I'm working on fixing it at the moment, should be an easy one

@SzymczakJ
Copy link
Contributor

I've found the fix for this bug, indeed it was caused by my PR.
I will push out a PR with all the fixes.

@techievivek
Copy link
Contributor

Should we export it as a new issue or is it a same root? Thanks

I think we can keep a single GH @IuliiaHerets, @SzymczakJ is working on fixing both of these bugs.

@techievivek
Copy link
Contributor

Bumped in Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1738211538596099 to see how is the progress here.

@Beamanator
Copy link
Contributor

Seems the PR that caused this may have been reverted, i will test in latest staging

@Beamanator
Copy link
Contributor

Wait this blocker was originally added to #56018, is this still happening on the latest versions??

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 3, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 3, 2025
@Beamanator
Copy link
Contributor

yeah this isn't reproducible anymore 👍 marking NAB but not closing b/c idk if payment is due (i don't think so since i think it was fixed due to a revert?)

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

@techievivek, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 11, 2025

@techievivek, @adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants