[Due for payment 2025-02-27] [HOLD for payment 2025-02-07] [$50] iOS - Reports - Top part of the filter button is cut off

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

1. Launch ND or hybrid app.
2. Go to Reports.

Expected Result:

The top part of the filter button will not be cut off.

Actual Result:

The top part of the filter button is cut off.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/bbc4cc90-77a6-4908-86c6-80dc692c69f0

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884239375862424462
• Upwork Job ID: 1884239375862424462
• Last Price Increase: 2025-01-28

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MariaHCD]

Minor UI issue so this does not need to block the deploy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884239375862424462

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Upwork job price has been updated to $50

[twisterdotcom]

It doesn't need to be Hourly either.

[faishal882]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Top part of the filter button is cutoff

What is the root cause of that problem?

The abve problem occurs because styles.zIndex10

App/src/pages/Search/SearchPageBottomTab.tsx

Lines 111 to 118 in 1ca2440

	<View style={[styles.zIndex10, styles.appBG]}>
	<TopBar
	activeWorkspaceID={policyID}
	breadcrumbLabel={translate('common.reports')}
	shouldDisplaySearch={shouldUseNarrowLayout}
	shouldDisplayCancelSearch={shouldDisplayCancelSearch}
	/>
	</View>

which overlaps with the Animated.View

App/src/pages/Search/SearchPageBottomTab.tsx

Lines 120 to 131 in 1ca2440

	<Animated.View style={[styles.searchTopBarStyle, topBarAnimatedStyle]}>
	<SearchTypeMenu
	queryJSON={queryJSON}
	searchName={searchName}
	/>
	<SearchStatusBar
	queryJSON={queryJSON}
	onStatusChange={() => {
	topBarOffset.set(withTiming(StyleUtils.searchHeaderHeight, {duration: ANIMATION_DURATION_IN_MS}));
	}}
	/>
	</Animated.View>

What changes do you think we should make in order to solve the problem?

we can increase tosearchHeaderHeight: 81 used in Animated.View style={[styles.searchTopBarStyle, topBarAnimatedStyle]}

App/src/styles/variables.ts

Line 278 in 1ca2440

searchHeaderHeight: 80,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

we can remove the styles.zIndex10 but it will alter the scrolling flow:
before:

before.webm

after(scrolling flow changed):

after.webm

[melvin-bot]

📣 @faishal882! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[faishal882]

Contributor details
Your Expensify account email: faishalmanzar@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017818ffe06866428b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[SzymczakJ]

I'm currently working on redesign of search page and the PR is pretty close to being merged. It will make this bug obsolete as the whole design will change(link).

I'll link this issue to my PR, so we know when it's fixed.

[sobitneupane]

Thanks @SzymczakJ

@twisterdotcom Let's hold/close this issue in favor of #55078

[twisterdotcom]

Let's just close then.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Redesign search to always show search input(mobile + desktop). #55078

If no regressions arise, payment will be issued on 2025-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

@sobitneupane @twisterdotcom @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add search input to mobile search page(with fixed performance) #56326

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

@sobitneupane @twisterdotcom @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]