[Due for payment 2025-02-19] [$250] Incorrect System Message Displayed When Deleting a Report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): expense

Action Performed:

1. Create a report and submit it to a test workspace.
2. Delete the report.
3. Observe the system message displayed.

Expected Result:

The message should clearly indicate what happened, such as:
"Moved expense from expense report to your personal space."

Actual Result:

The message displayed: "Moved expense from self DM to chat with"
"Self DM" is not a recognized product feature

The screenshot for the issue is in OP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021887252495070927393
• Upwork Job ID: 1887252495070927393
• Last Price Increase: 2025-02-05
• Automatic offers:
• paultsimura | Reviewer | 106012766
• linhvovan29546 | Contributor | 106012768

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[dominictb]

I can reproduce:

1. Create an expense in self DM
2. Press Share it with my accountant
3. Complete the share flow to any workspace
4. Open the expense just moved from self DM to workspace chat
5. Verify message says "Moved expense from self DM to chat with"

@kadiealexander I can take this over.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The message displayed: "Moved expense from self DM to chat with"
"Self DM" is not a recognized product feature

What is the root cause of that problem?

This is a copy update

What changes do you think we should make in order to solve the problem?

Modify these self DM here to personal space or something:

App/src/languages/en.ts

Lines 998 to 999 in bfb97c5

	movedFromSelfDM: ({workspaceName, reportName}: MovedFromSelfDMParams) => `moved expense from self DM to ${workspaceName ?? `chat with ${reportName}`}`,
	movedToSelfDM: 'moved expense to self DM',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[hoangzinh]

@dominictb it seems you missed "delete report" step.

[linhvovan29546]

@MarioExpensify @paultsimura The message 'moved expense to self DM' came from my PR. Should we follow up on this?

[paultsimura]

Hi @quinthar, the "self DM" copy originally comes from "share expense" flow. It was approved here: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1733390159603739?thread_ts=1729611433.691999&channel=C01GTK53T8Q&message_ts=1733390159.603739

If "self DM" is incorrect, could you please provide valid copies for both scenarios?

We can update it with @linhvovan29546 as a follow up.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021887252495070927393

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pecanoro]

@paultsimura This is the proposal you are approving, right? #56322 (comment)

[paultsimura]

Sorry, @pecanoro, we've summoned you to help us with a copy approval.
There won't be a proposal review as we're taking it with @linhvovan29546 as a follow-up.

My main concern/question is this: #56322 (comment).
I tried tagging @quinthar in Slack, but no response so far.

[pecanoro]

Gotcha! Let me ping him in the thread since I don't have an answer when it comes to the copy

[paultsimura]

We've received an approval on the copies:

EN:
- 'moved expense from personal space to chat with ...',
- 'moved expense to personal space',

ES:
- movió el gasto desde su espacio personal a un chat con ...
- movió el gasto a su espacio personal

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: inccorect system message when deleteting a report from od #56440

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Reviewer)
• @linhvovan29546 requires payment automatic offer (Contributor)

[melvin-bot]

@paultsimura @kadiealexander @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@pecanoro @paultsimura @kadiealexander @linhvovan29546 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[paultsimura]

@pecanoro, I guess this one can be closed without payment because it was a follow-up.

[pecanoro]

Sounds good! Closing!