[HOLD for payment 2022-03-22] Height of input box for entering room name is wrong and it does not highlight when focused - Reported by @parasharrajat

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to "+" > New Room
3. Hit in the box or hover

Expected Result:

Input box should have blue border when focused.

Actual Result:

Height of input box for entering room name is wrong and it does not highlight when focused

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Upwork job link https://www.upwork.com/jobs/~01a4c8aadd3c3f0685
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642356868030500

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

As I reported this, I would like to fix this issue in one of my PR for #6584. When I will refactor the TextInputWithPrefix, I will fix this too.

[neil-marcellini]

Thanks I'll assign this one to you.

[parasharrajat]

Thanks @neil-marcellini but maybe we can get this external first for reporting it.

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

This issue has not been updated in over 15 days. @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[parasharrajat]

This needs to be exported for reporting bonus. I am happy to fix it under #6584. Randomly picking cc: @michaelhaxhiu as no one is assigned.

[michaelhaxhiu]

@parasharrajat https://www.upwork.com/jobs/~01a4c8aadd3c3f0685

[michaelhaxhiu]

You will be paid for the fix in #6584, correct? So this will just be the $250 reporting bonus based on what I'm seeing!

[parasharrajat]

So I am refactoring the same component as part of #6584 so I am happy to fix this on that and thus you are correct. Thanks.

[michaelhaxhiu]

cool crystal clear 💎

[michaelhaxhiu]

thanks for offering to do that also, @parasharrajat

[parasharrajat]

@shawnborton I am planning to merge this TextinpuT(attached on the screenshot) In our usual TextInput. I have some questions about the design. I would be glad if you could help here. Thanks.

1. What should happen to the label? Should I keep it above the input for when there is a prefix?
2. What about the height of the input? Should it be small like this or normal as per TextInput?

[shawnborton]

• I think the height of this input should be just like other text inputs (52px)
• I think in this case, we could try having a floating label that says "Room name" and remove the label above the input that we currently have. But I think it might look cleaner to not use a floating label. What do you think?

[parasharrajat]

I am curious. How will it look with the floating label over the prefix and input area?

Are you suggesting that we just use the placeholder?

Here are some example..

[parasharrajat]

Gentle bump @shawnborton

[shawnborton]

Apologies, was OOO for the past few days.

One option is to just always keep the input as if it was in the "has value" state, but we actually move the input portion over to the right after a fixed #:

Thoughts on that?

[parasharrajat]

Looks good to me.

[puneetlath]

@michaelhaxhiu assigning you to make sure we pay Rajat for reporting this issue.

[michaelhaxhiu]

#7937 (comment)
This comment suggests that the payout for rajat should go from $250 -> $500 for this GH right?

Additionally, he'll receive $250 via #6584, right?

[parasharrajat]

So here is the summary for payout.

1. I am fixing this as part of [HOLD for payment 2022-04-01] Simplify/consolidate our various Text Input components #6584. [HOLD for payment 2022-03-22] Height of input box for entering room name is wrong and it does not highlight when focused - Reported by @parasharrajat #7308 (comment) => Payment to fix it.
2. Here you will add reporting bonus
3. @puneetlath mentioned adding a bonus for some additional work Merge TextInputWithPrefix into TextInput #7937 (comment).

I think I am fine without point 3. I say the change was small and quick so I don't want the bonus for that.

[michaelhaxhiu]

I think we should pay you for point 3 and noticed puneet agreed too in his latest comment.

It sounds like the additional $250 should be added to the other GH #6584 (not this one)? Is that correct?

[parasharrajat]

Yup that would be added to other issue not this one. Here only reporting bonus needs to be paid off.

[michaelhaxhiu]

Thanks for confirming.

[michaelhaxhiu]

Waiting for this PR to go to production, and then I'll pay Rajat $250 for reporting this bug + close this GH.

[michaelhaxhiu]

Paid!