[HOLD for payment 2022-02-08] Close Account warning modal shown on opening the page - reported by @parasharrajat

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the close account page from Settings => Close Account.
2. fill required info, Click close account.
3. Now there is a modal is shown for some accounts.
4. Now close the app without closing the modal.
5. Restart the app and go back the close account page.

Expected Result:

Modal should not display on opening

Actual Result:

Close Account warning modal shown on opening the page

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-2022-01-15_23.57.25.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642271359491600

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Waiting for triage before putting a proposal...

[mountiny]

cc @Julesssss might be the best one to handle this CME if this would be made External.

[danieldoglas]

Confirmed this is a bug that can be fixed through updates in the App only.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Yeah, we can fix it from the app easily.

Proposal

1. We should use initWithStoredValues: false for this key

   App/src/pages/settings/Security/CloseAccountPage.js

   Line 143 in 7dfe96f

   key: ONYXKEYS.IS_CLOSE_ACCOUNT_MODAL_OPEN,

   .

so that it does not take stored values. This key is supposed to be used on runtime in one session.

[Julesssss]

Hmm, why didn't the automated message show, I don't see the missing step 😕

[Julesssss]

Okay, I think we're missing HelpWanted as the UpWork issue hasn't yet been created. Let's await that.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Current assignee @Julesssss is eligible for the Exported assigner, not assigning anyone new.

[mallenexpensify]

Got a lil behind this week, job's posted https://www.upwork.com/jobs/~01871dd2f8bd13e321

[jahanzaibbaloch99]

@mallenexpensify in the reference of Upwork proposal.
There are two possible way i could achieve this.

1- on CloseAccountpage.js file we would call the componentWillunmount and check with condition if user has Going back from the page without setting modal state to false we would update the modal state to its initial state which is false.

2- on CloseAccountPage.js file we would Check the App state if the user Quit the app without Setting modal state to false we would update the modal state to its initial state which is false.

[Julesssss]

Proposal

1. We should use initWithStoredValues: false for this key

   App/src/pages/settings/Security/CloseAccountPage.js

   Line 143 in 7dfe96f

   key: ONYXKEYS.IS_CLOSE_ACCOUNT_MODAL_OPEN,

I forgot to implement this when building the close account page, it's the correct solution.

[MelvinBot]

📣 @parasharrajat You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

@jahanzaibbaloch99 , thanks for chiming in. This was a pretty quick fix that @parasharrajat had already provided an acceptable solution. If you're looking for more jobs, this link will show all the one's with the Help Wanted label.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.33-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Correct close account confirmation modal logic. #7368

If no regressions arise, payment will be issued on 2022-02-08. 🎊

[mallenexpensify]

@parasharrajat , hired you in Upwork, let me know when you've accepted. Payment will be $500, $250 for reporting and fix.

[mallenexpensify]

Paid