Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct close account confirmation modal logic. #7368

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #7315

Tests | QA Steps

  1. Open the close account page from Settings => Close Account.
  2. fill required info, Click close account.
  3. Now there is a modal is shown for some accounts.
  4. Now close the app without closing the modal.
  5. Restart the app and go back the close account page.
  6. Close Modal should not show on page load.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

screen-2022-01-24_20.35.45.mp4

Mobile Web

iOS

Same effect as Android. Its configuration change.

Android

screen-2022-01-24_20.38.21.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner January 24, 2022 15:11
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team January 24, 2022 15:11
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

@Julesssss Julesssss merged commit 5e268df into Expensify:main Jan 25, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants