[HOLD for payment 2022-05-24][$1000] Native Apps - There is an extra space above codeblocks in android and IOS - reported by @sobitneupane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send codeblock with message above and below:
   Here is come code

   const myLineOfCode = 'some code';
   

Expected Result:

Same output in all platforms.

Actual Result:

Extra space above codeblocks in android and IOS.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Related to #7496 (comment)

Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644507497800049

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MonilBhavsar]

Looks like <Text> component is occupying more than half of height of <ReportActionItemGrouped> component

Not blocking anything and occurs on iOS/Android, so low priority

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[JmillsExpensify]

Agreed, not an incredible priority. I'll go ahead and create an Upwork job because I do agree we should polish. Job is here: https://www.upwork.com/jobs/~0127315d24f0e23219

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @marcochavezf (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[JmillsExpensify]

Still waiting for volunteers. Increased the Upwork job to $500 per the process.

[JmillsExpensify]

Still waiting on volunteers. Increasing the price to $1000, which is ironic given this isn't incredibly pressing, but I'd like to stay true to the process here.

[aneequeahmad]

PROPOSAL

CAUSE OF ISSUE

Converting the comment from MD into HTML in addAction function(Report.js) is causing the issue. ExpensiMark.js replace function is called with message text that applies rules to text to ensure that any Html the user puts into the comment field shows as raw Html. In the rules below rule

 {
                // when <pre> and <br /> occur together extra line is added so removing <br />
                name: 'replacepre',
                regex: /<\/pre>\s*<br\s*[/]?>/gi,
                replacement: '</pre>',
     },
     

is not replacing <br /><pre> with <pre> to remove extra line added but only removes <pre>

BEST POSSIBLE SOLUTION

This rule when added

     {
                //  when <br /> and <pre> occur together extra line is added remove <br />
                name: 'replacebr',
                regex: /<br\s*[\/]?><pre>\s*/gi,  
                replacement: '<pre>'
            }

replaces <br /><pre> with <pre> which fixes the issue.

TO BE NOTED AND NEED SUGGESTION
Also this regex /<\/pre>\s*<br\s*[/]?>/gi doesn't seem to be valid so replacing it with /<\/pre>\s*<br\s*[\/]?>/gi to make this regex valid.

ScreenShot is attached after the fix is applied.

[JmillsExpensify]

@rushatgabhane Circling back on this one because we owe feedback for this proposal. Thanks!

[JmillsExpensify]

Thanks @marcochavezf! Looks like we have a couple of updates in the linked PR.

[aneequeahmad]

@JmillsExpensify, The Upwork job is no longer available for some reason. PR is merged and PR for App is raised as well. Thanks

[JmillsExpensify]

No worries. I've got you covered here: https://www.upwork.com/jobs/~012ed1a030f60ce0f5. Can you apply? Then we can issue payment once the standard regression period ends.

[JmillsExpensify]

cc @sobitneupane and @rushatgabhane as well for the new job posting.

[aneequeahmad]

@JmillsExpensify Applied, yeah sounds good let's wait for the regression period. Thanks for your message.

[JmillsExpensify]

Still working through considerations in the last linked PR.

[JmillsExpensify]

Working through issues in the linked PR to get the project running. No progress since last week.

[rushatgabhane]

Interesting..

Looks like @aneequeahmad's changes to expensify-common hit production 3 days ago because of an another PR #8948, which updated expensify-common to a more up-to-date version.

If @marcochavezf agrees with me as well, we can ask the QA team to test this issue and close it out in 7 days.

[marcochavezf]

Yeah, it's interesting that expensify-common was eventually updated in E/App because of another PR. Thanks for testing again on Android @rushatgabhane!

If @marcochavezf agrees with me as well, we can ask the QA team to test this issue and close it out in 7 days.

Sure, sounds like a good plan to me! I already sent a message to the QA team to test again.

[mvtglobally]

@marcochavezf
Can you confirm the build to test this on?

[rushatgabhane]

@mvtglobally production build on mobile platforms.

[JmillsExpensify]

Thanks everyone! So based on when #8948 hit production, today is the end of the regression period. Accordingly, I'm holding to hold for the next QA test. Assuming that is happening sometime today, so @mvtglobally it'd be great if you can confirm when this passes. I'll go ahead and put a hold for payment tomorrow.

[mvtglobally]

@JmillsExpensify @rushatgabhane
It seems like there is still some gap and issue is repro. See below

[rushatgabhane]

@mvtglobally all those look like they're different messages.

Can we try that again with a single message and see if it works?

[aneequeahmad]

@JmillsExpensify The Upwork job is no longer available, also i haven't been hired for this job.
Could i ask when the payment will be issued ? I'm unaware of the process as this is my first job. Thanks

[rushatgabhane]

@aneequeahmad the job might have expired and a new one will be created.

Could i ask when the payment will be issued

Once the issue is not reproducible by the QA team, the payments will be settled.
Thanks for understanding!

[aneequeahmad]

@rushatgabhane Ahhh alright! thank you for your comment 🥇

[JmillsExpensify]

@JmillsExpensify The Upwork job is no longer available, also i haven't been hired for this job. Could i ask when the payment will be issued ? I'm unaware of the process as this is my first job. Thanks

You're good! You already applied to the existing job post here: https://www.upwork.com/jobs/~012ed1a030f60ce0f5. I've hired you, same for @rushatgabhane as C+ and @sobitneupane for reporting. Thanks all, let me know we still have any issues.

[JmillsExpensify]

@mvtglobally I just tested this on the latest build and I think we're good. Would you mind confirming so we can close this out in the next QA round? Thanks!

[mvtglobally]

@JmillsExpensify @rushatgabhane
I think it's looking good

[rushatgabhane]

Fantastic, thanks everyone!

[JmillsExpensify]

Ok great! I've just issued payments to all contributors, so I'm closing the issue. Don't hesitate to follow-up with any questions!