Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest expensify-common #8948

Merged
merged 1 commit into from
May 11, 2022
Merged

Use latest expensify-common #8948

merged 1 commit into from
May 11, 2022

Conversation

arosiclair
Copy link
Contributor

@arosiclair arosiclair commented May 11, 2022

Fixes issues with sending or editing messages with empty markdown tags. This was already more thoroughly detailed and tested in this PR: Expensify/expensify-common#443

Fixed Issues

$ #8720

Tests

  • Verify that no errors appear in the JS console
  1. Log in
  2. Start a chat conversation
  3. Send a message with empty backticks (code block with no text in-between)
  4. Verify empty backticks are sent and NOT an empty code block
  5. Send a message with empty code fence backticks
  6. Verify 2 code blocks with a back tick in each is sent and NOT an empty code fence
  7. Send a message with a markdown link with no text
  8. Verify the text is sent as is and an invisible link is NOT sent

QA Steps

Same as Tests section

fixes issues with sending or editing messages with empty markdown tags
@arosiclair arosiclair requested a review from a team as a code owner May 11, 2022 18:46
@arosiclair arosiclair self-assigned this May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team May 11, 2022 18:47
@arosiclair
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@arosiclair arosiclair changed the title [WIP] Use latest expensify-common Use latest expensify-common May 11, 2022
Copy link
Contributor

@amyevans amyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit hash is accurate, good to go 👍

@amyevans amyevans merged commit a0ce5d2 into main May 11, 2022
@amyevans amyevans deleted the arosiclair-common-update branch May 11, 2022 21:21
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @amyevans in version: 1.1.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants