Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2022-05-26] [$1000] iOS/ Android - Attachment - Image looks cropped In the Preview page #8115

Closed
kbecciv opened this issue Mar 13, 2022 · 56 comments
Closed

[HOLD for payment 2022-05-26] [$1000] iOS/ Android - Attachment - Image looks cropped In the Preview page #8115

kbecciv opened this issue Mar 13, 2022 · 56 comments
Assignees
@shawnborton @AndrewGable @mallenexpensify @jboniface @mollfpr @Santhosh-Sellavel
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Mar 13, 2022 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Go to a chat
  3. Click on the "+" sign
  4. Select add Attachment
  5. Select a screenshot (mad from your phone)

Expected Result:

Attached screenshot should fully visible in Preview page

Actual Result:

Attached screenshot is not fully visible in Preview page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.42.4

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+le@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Bug5488808_Image_Bug_QA.mp4

Slack conversation:

View all open jobs on GitHub
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 13, 2022
@OSBotify OSBotify mentioned this issue Mar 13, 2022
Closed
@OSBotify

This comment was marked as outdated.

Sign in to view
@MelvinBot
Copy link

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv added Emergency Daily KSv2 Engineering and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Emergency labels Mar 13, 2022
@MelvinBot
Copy link

Current assignee @timszot is eligible for the Engineering assigner, not assigning anyone new.

@timszot timszot added the External Added to denote the issue can be worked on by a contributor label Mar 14, 2022
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@kadiealexander
Copy link
Contributor

Posted to Upwork!

External: https://www.upwork.com/jobs/~01fe2aa229cf3ecd0d
Internal: https://www.upwork.com/ab/applicants/1503501207937069056/job-details

@botify botify removed the Daily KSv2 label Mar 14, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Mar 14, 2022
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 14, 2022
@MelvinBot
Copy link

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Apr 27, 2022

📣 @mollfpr You have been assigned to this job by @AndrewGable!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2022
@mollfpr mollfpr mentioned this issue Apr 27, 2022
Merged
89 tasks
@Santhosh-Sellavel Santhosh-Sellavel mentioned this issue May 3, 2022
Closed
@melvin-bot melvin-bot bot added the Overdue label May 5, 2022
@AndrewGable AndrewGable added the Reviewing Has a PR in review label May 5, 2022
@melvin-bot melvin-bot bot removed the Overdue label May 5, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-05-26. 🎊

@melvin-bot melvin-bot bot changed the title [$1000] iOS/ Android - Attachment - Image looks cropped In the Preview page [HOLD for payment 2022-05-26] [$1000] iOS/ Android - Attachment - Image looks cropped In the Preview page May 19, 2022
@mollfpr
Copy link
Contributor

mollfpr commented May 23, 2022

@AndrewGable @thienlnam Just curious, is I eligible for the pay for solving this #8363 issue? 😅

Since it’s different with my proposal here #8115 (comment) for solving the initial issue, and here #8115 (comment) for solving the a gap on Android.

@Santhosh-Sellavel
Copy link
Collaborator

@AndrewGable @thienlnam Just curious, is I eligible for the pay for solving this #8363 issue? 😅

Since it’s different with my proposal here #8115 (comment) for solving the initial issue, and here #8115 (comment) for solving the gap on Android.

I'm afraid not since it's well within the scope of the same issue! If then I would get an additional C+ too 😅 ?

As far as I can see the only thing that's maybe eligible is reporting bonus for #8363 Reporter.

@AndrewGable
Copy link
Contributor

@jboniface - Mind taking a look into that?

@jboniface
Copy link

@AndrewGable @Santhosh-Sellavel @mollfpr it looks like #8363 was closed as duplicate. I don't think it makes sense to pay for it.

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, @jboniface Can you set up a job for this one or send invites. I can't find the Upwork link for this one. Thanks!

@jboniface
Copy link

yep, it must have expired https://www.upwork.com/jobs/~017240c85f844e057f

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, @jboniface Applied!

@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels May 25, 2022
@mallenexpensify
Copy link
Contributor

Hired @Santhosh-Sellavel and @mollfpr for $1000 each, please accept and confirm here then I'll pay tomorrow
https://www.upwork.com/jobs/~017240c85f844e057f

@Santhosh-Sellavel
Copy link
Collaborator

Done,
@mallenexpensify Thanks!

@mollfpr
Copy link
Contributor

mollfpr commented May 30, 2022

@mallenexpensify applied!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 31, 2022 •
edited
Loading

@Santhosh-Sellavel and @mollfpr paid $1k/each (note to self.. @mollfpr 's contract was set as milestone (likely by mistake by me) in case it looks different)

Thanks for the help!

@Santhosh-Sellavel Santhosh-Sellavel mentioned this issue Jan 30, 2023
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnborton shawnborton

@AndrewGable AndrewGable

@mallenexpensify mallenexpensify

@jboniface jboniface

@mollfpr mollfpr

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests