Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Workspace name is not fully visible under all Workspace Settings - reported by: @adeel0202 #8321

Closed
kbecciv opened this issue Mar 25, 2022 · 22 comments
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Mar 25, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with expensifail account
  3. Go to Setting - Workspace - General setting
  4. Type long name and save

Expected Result:

Workspace name is fully visible under all Workspace Settings

Actual Result:

Workspace name is fully visible under all Workspace Settings

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.46.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+0709abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5506153_Recording__478.mp4

Issue 3
Issue1
Issue3

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Mar 25, 2022

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

parasharrajat commented Mar 25, 2022

cc: @mananjadhav Possible regression from your change.

@mananjadhav
Copy link
Collaborator

mananjadhav commented Mar 25, 2022

PR that I worked on dealt with adding a component to subtitle prop so that the filename + ext both are visible. Still think its a regression from that PR?

@parasharrajat
Copy link
Member

parasharrajat commented Mar 25, 2022

Sorry, my bad. Regression from #8065. Actually, you reported that issue #7840 so I got confused.

cc: @rushatgabhane

@rushatgabhane
Copy link
Member

Oh man.. Gotta make a test account which has all such edge cases, so it's easier to catch them.

Anyway, thanks for the tag. We just have to ellipse it right?

@rushatgabhane
Copy link
Member

rushatgabhane commented Mar 25, 2022

If we just need to ellipse it, we can add numberOfLines={1} prop to Text over here.

? Boolean(props.subtitle) && <Text style={[styles.mutedTextLabel]}>{props.subtitle}</Text>

Screen Shot 2022-03-26 at 1 20 53 AM

Feel free to take it internal

@MelvinBot
Copy link

@Justicea83 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Justicea83
Copy link
Contributor

working on it

@adeel0202
Copy link
Contributor

I don't know who to tag here but I reported this bug on slack here before this issue was created on GH, so I think I'm eligible for the reporting bonus :)

@rushatgabhane
Copy link
Member

I don't know who to tag here but I reported this bug on slack here before this issue was created on GH, so I think I'm eligible for the reporting bonus

@michaelhaxhiu you wanna pick this one?

@MelvinBot
Copy link

@Justicea83 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

@Justicea83 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

@Justicea83 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@michaelhaxhiu
Copy link
Contributor

On it now.

@adeel0202 can you apply to this job please? https://www.upwork.com/jobs/~01c0b7bd5864dfaa03

@michaelhaxhiu michaelhaxhiu changed the title Workspace - Workspace name is not fully visible under all Workspace Settings Workspace - Workspace name is not fully visible under all Workspace Settings - reported by: @adeel0202 Apr 11, 2022
@michaelhaxhiu
Copy link
Contributor

Paid

@melvin-bot
Copy link

melvin-bot bot commented Apr 13, 2022

@Justicea83 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented Apr 15, 2022

@Justicea83 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 18, 2022

This issue has not been updated in over 14 days. @Justicea83 eroding to Weekly issue.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

This issue has not been updated in over 15 days. @Justicea83 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) @michaelhaxhiu are we ok to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants