Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2022-03-24] Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav #7840

Closed
mvtglobally opened this issue Feb 20, 2022 · 20 comments
Closed

[HOLD for payment 2022-03-24] Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav #7840

mvtglobally opened this issue Feb 20, 2022 · 20 comments
Assignees
@NicMendonca @rushatgabhane @Luke9389 @dylanexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Create workspace
  2. Navigate to Settings and click through different screens (such as "Reimburse receipts", "Pay bills", "Manage members", etc.)

Expected Result:

Add workspace name in the subtitle on settings.

Actual Result:

No workspace name currently shows.
To verify if the user is on the correct workspace, he/she will have to go back to the previous screen to see the workspace name. It'll be better if we show the workspace name in the header of the modal itself.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
without-workspace-name
with-workspace-name
Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644267323975329

View all open jobs on GitHub
@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Feb 20, 2022
@MelvinBot
Copy link

Triggered auto assignment to @SofiedeVreese (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Feb 20, 2022
@mananjadhav
Copy link
Collaborator

mananjadhav commented Feb 20, 2022 •
edited
Loading

Writing a quick proposal as I posted this feature request.

In WorkspacePageWithSections, we pass workspace name to the subtitle Prop of HeaderWithCloseButton here

https://github.com/stardev115/Expensify/blob/9d6e07a0d3bb298d7edba16824efb95afc94f280/src/pages/workspace/WorkspacePageWithSections.js#L75

@MelvinBot
Copy link

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@SofiedeVreese
Copy link
Contributor

Issue LGTM, adding Engineering.

@SofiedeVreese
Copy link
Contributor

Whoops, adding Luke back in, Melvinbot accidentally removed us both when I only wanted to remove my assignment.

@Luke9389 Luke9389 added Weekly KSv2 Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 Weekly KSv2 labels Feb 22, 2022
@MelvinBot
Copy link

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Luke9389 Luke9389 added Weekly KSv2 and removed Daily KSv2 labels Feb 22, 2022
@dylanexpensify
Copy link
Contributor

Getting posted!

@MelvinBot MelvinBot removed the Overdue label Mar 4, 2022
@dylanexpensify
Copy link
Contributor

Posted!

Internal: https://www.upwork.com/ab/applicants/1499687100051460096/job-details
External: https://www.upwork.com/jobs/~01eb90d36fc078a9f0

@botify botify removed the Weekly KSv2 label Mar 4, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Mar 4, 2022
@rushatgabhane
Copy link
Member

🎀 👀 🎀 C+ reviewed

@Luke9389 I recommend @mollfpr's proposal

@Luke9389
Copy link
Contributor

Luke9389 commented Mar 8, 2022

Cool, looks good to me. Go for it @mollfpr 👍

@mollfpr
Copy link
Contributor

mollfpr commented Mar 8, 2022

@rushatgabhane @Luke9389 Thanks, guys! I’ll work on it ASAP!

@mollfpr
Copy link
Contributor

mollfpr commented Mar 8, 2022

@dylanexpensify Applied to Upwork, thank you!

This was referenced Mar 8, 2022
Closed
Merged
@dylanexpensify dylanexpensify removed their assignment Mar 11, 2022
@dylanexpensify dylanexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Mar 11, 2022
@MelvinBot
Copy link

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Mar 11, 2022
@dylanexpensify
Copy link
Contributor

Reassigning as I'm OOO next week! Thanks Nicole! I'll pick this up when I'm back!

@dylanexpensify dylanexpensify self-assigned this Mar 11, 2022
@MelvinBot MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 11, 2022
@dylanexpensify
Copy link
Contributor

@rushatgabhane @mollfpr @mananjadhav sent you each an offer in Upwork!

@dylanexpensify dylanexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 11, 2022
@mountiny mountiny added the NewFeature Something to build that is a new item. label Mar 11, 2022
@botify botify added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 17, 2022
@botify botify changed the title Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav [HOLD for payment 2022-03-24] Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav Mar 17, 2022
@botify
Copy link

botify commented Mar 17, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-03-24. 🎊

@botify botify removed the Weekly KSv2 label Mar 23, 2022
@MelvinBot MelvinBot added the Daily KSv2 label Mar 23, 2022
@dylanexpensify
Copy link
Contributor

Payments sent, contracts ended, posting closed! Thanks for playing y'all!

@parasharrajat parasharrajat mentioned this issue Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicMendonca NicMendonca

@rushatgabhane rushatgabhane

@Luke9389 Luke9389

@dylanexpensify dylanexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests