Add workspace name as subtitle in individual modal screens #8038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adding workspace name that get from props
withFullPolicy
hoc and call thethis.props.policy.name
and pass it toHeaderWithCloseButton
component.Update
workspace
page included:workspace/${policyID}/invite
workspace/${policyID}/settings
workspace/${policyID}/card
workspace/${policyID}/reimburse
workspace/${policyID}/bills
workspace/${policyID}/invoices
workspace/${policyID}/travel
workspace/${policyID}/bank-account
Fixed Issues
$ #7840
Tests
Open
workspace
page, open the page below, and verify that the workspace name is shown in the modal header.workspace/${policyID}/invite
workspace/${policyID}/settings
workspace/${policyID}/card
workspace/${policyID}/reimburse
workspace/${policyID}/bills
workspace/${policyID}/invoices
workspace/${policyID}/travel
workspace/${policyID}/bank-account
PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)PR Reviewer Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)main
branch)QA Steps
Open
workspace
page, open the page below, and verify that the workspace name is shown in the modal header.workspace/${policyID}/invite
workspace/${policyID}/settings
workspace/${policyID}/card
workspace/${policyID}/reimburse
workspace/${policyID}/bills
workspace/${policyID}/invoices
workspace/${policyID}/travel
workspace/${policyID}/bank-account
Screenshots
Web
Screen.Recording.2022-03-08.at.18.13.21.mov
Mobile Web
Screen.Recording.2022-03-08.at.17.59.03.mov
Desktop
Screen.Recording.2022-03-08.at.18.01.34.mov
iOS
Screen.Recording.2022-03-08.at.18.11.17.mov
Android
Screen.Recording.2022-03-08.at.18.14.03.mov