[HOLD for payment 2022-05-02] [$250] Close account page input field label doesn't fit in one line (Español) - reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to preferences page and change your language to Español
2. Go to close account page check the second input for entering default contact method
3. Add some text

Expected Result:

The label text should be in a single line

Actual Result:

Label doesn't fit in one line

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647851496725259

Job Post https://www.upwork.com/ab/applicants/1515111330801573888/job-details

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kadiealexander]

Yes, I can see this too! The instruction text isn't aligned properly:

And it doesn't disappear when you input text:

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Hmmm, asked about it in Slack

[flodnv]

@thesahindia @mvtglobally @kadiealexander this is a tricky one. I don't see any great option. We could:

1. Change it to Introduce tu metodo de contacto, but we use metodo de contacto predeterminado everywhere
2. Do nothing
3. ???

😕

[thesahindia]

Maybe something like this -

[flodnv]

Hmmmm this could work, thoughts @Julesssss @luacmartins ?

[luacmartins]

Hmm I'm not a big fan of the input without labels and that might fail accessibility features as well.

I think another option is to have the user type a static string, e.g. CLOSE or DELETE. We seem to only use it to disable the Close account button and that would serve the same fat finger prevention/intentional action confirmation purpose. We could also get rid of the default contact method above the input. It would look something like this:

[Julesssss]

Hmm, I suppose it's a good enough solution. It would be good to enforce that this is a dangerous task though. Something like 'I understand', or at least the full 'close account'?

[flodnv]

Asking again in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1649773232745629

[flodnv]

We are going with: remove Introduce from the translation.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

Proposal

I would like to take this.
We have to remove Introduce here -

App/src/languages/es.js

Line 325 in c237f36

enterDefaultContact: 'Introduce tu método de contacto predeterminado',

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@luacmartins unassigning myself because C+ review isn't required here, and the solution was found on slack.

[luacmartins]

@thesahindia proposal looks good!

[melvin-bot]

📣 @thesahindia You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[thesahindia]

I have raised the PR.

[kevinksullivan]

@thesahindia please accept the offer in upwork when you get a chance!

[thesahindia]

@kevinksullivan, I have applied to the job ✅ .

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.56-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• make the label smaller as it doesn't fit in the field #8694

If no regressions arise, payment will be issued on 2022-05-02. 🎊

[kevinksullivan]

@thesahindia just a heads up the offer still looks like it's awaiting your acceptance!

[thesahindia]

@thesahindia just a heads up the offer still looks like it's awaiting your acceptance!

Hi @kevinksullivan, I am getting error when trying to accept the offer. I thought there's some problem in upwork or my account but I just accepted a different offer so I guess it's working fine.

[kevinksullivan]

Hmm @thesahindia I just withdrew the offer and resent it. Let me know if that works!

[thesahindia]

@kevinksullivan, it worked.
Thanks.

[kevinksullivan]

Paid for reporting and completion. Thanks @thesahindia !