Payment - User can't continue after reaching "Save & Continue"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-Condition: Have a workspace created

1. Open the Expensify iOS app
2. Log in to a applause.expensifail.com account
3. Tap on "Profile" icon > "Payments" > "Add payment method" > "Bank Account"
4. Proceed with the flow until the "Account type & Password" page
5. Tap "Save & Continue"

Expected Result:

The user expects to be able to add a deposit bank account through this flow

Actual Result:

The user wont be able to proceed beyond this "Save & continue' page, the button will "Load" and return to its initial state

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.63-2

Reproducible in staging?: Y

Reproducible in production?: No (Not able to check in production)

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5577168_Cant_continue_beyond_Save___Continue.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[techievivek]

I looked into the issue and can see that it throws the error and the reason being the account that you are trying to add is already previously added.

bankaccount? [hmmm] [mobile] API threw ExpError Expensify\Libs\Error\ExpError - 15fc249e-1f89-49be-aa78-1d87132bf9c5 ~~ exceptionJsonCode: '666' exceptionUserMessage: 'Bank account can't be created, it looks like a bank account with the same information already exists in your account.' exceptionMessage: 'Bank account can't be created, it looks like a bank account with the same information already exists in your account.' exceptionFile: '/vagrant/Web-Secure/lib/BankAccountAPI.php' exceptionLine: '883' exceptionCode: '666'

I also tested this with a new account where no bank accounts are added and it worked without any errors.
So a solution would be to show the error message to the user in the app.

[techievivek]

@kavimuru Can you confirm if you had already added this bank account before? or did you try adding this as a bank account in one of the workspaces?

[techievivek]

@AndrewGable Can you please cross-check this. Thanks

[parasharrajat]

I am already fixing this here #9023 as part of #7185

But I think #9085 (comment) is not the best solution due to the reason.

[techievivek]

So I think we can close this one then and yeah #9085 (comment) would be the best solution here.

[parasharrajat]

But I think we should fix where we check for the duplicate accounts so that it does not show duplicate accounts for selection instead of showing the error. This logic should successfully filter the existing accounts. But currently, it is not. It may be due to testing accounts.

App/src/libs/actions/Plaid.js

Line 64 in 572f6cb

plaidBankAccounts = _.filter(response.accounts, account => !account.alreadyExists);

Sorry, I meant to say that #9085 (comment) is not the best solution. Mistyping...

[techievivek]

Did you request a copy for your fix? I think we can just go with whatever they suggest.

And about the other concern while trying to reproduce this locally I saw an inconsistency when I added the same saving account by going through Profile -> Payment -> Add payment method it did filter out the already added account when I reattempted to add a new bank account. But when I added the same bank account by going into the workspace and left it incomplete and then came back to the previous flow Profile -> Payment -> Add payment method it got stuck at Save & Continue.

[parasharrajat]

Thanks. I am also concerned about the filtering of existing accounts. It is clearly an issue with that filtration. Code is designed to hide existing accounts from the dropdown so we should improve this logic to successfully filter all existing accounts. But if there is a possibility of an edge case where we are getting this error, then we can go with showing the error on the UI.

At last, we can keep this open for tracking and I can add this to my PR in the fixed issues list.

[techievivek]

It indeed is related to filtration logic, I think the current logic only hides the bank accounts which has been successfully added but for bank accounts that are in process of being added(You can mimic this by trying to add a bank account under one of the workspaces but leave it incomplete) are shown in the dropdown. But when you click on Save & Continue it reports the bank account is already added. Strange!

This is what the progress of adding a bank account in my workspace looks like.

Anyway making this a Daily for now.

[AndrewGable]

Since this issue sounds like it's on production as part of #7185 - Going to remove deploy blocker label.

[techievivek]

Not overdue.

[melvin-bot]

@techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[techievivek]

Not overdue

[techievivek]

@parasharrajat Hi 👋 Is this getting fixed in your PR?

[parasharrajat]

@techievivek No yet. I am waiting on update from @chiragsalian #7185 (comment).

[techievivek]

Not overdue.

[techievivek]

Not overdue. Work is in progress.

[techievivek]

Not overdue. Updating this to Weekly.

[techievivek]

Not overdue.

[techievivek]

Not overdue.

[techievivek]

Not overdue, @parasharrajat Can you give an update for this one 🙌 .

[parasharrajat]

The other PR is is about to be deployed on production and then I will complete my changes.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[techievivek]

Not overdue.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[AndrewGable]

If it's not reproducible 2x let's close

[parasharrajat]

Yes, we fixed it from the backend #7185 (comment)