Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-05-19 #9099

Closed
24 tasks done
OSBotify opened this issue May 19, 2022 · 12 comments
Closed
24 tasks done

Deploy Checklist: New Expensify 2022-05-19 #9099

OSBotify opened this issue May 19, 2022 · 12 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 19, 2022

Release Version: 1.1.64-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 19, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.64-0 🚀

@mvtglobally
Copy link

@AndrewGable Regression is complete
Clean run, not blockers.
We are finishing up #8832 with new steps provided.

@AndrewGable
Copy link
Contributor

Thanks @mvtglobally! Nice work this week on the checklists 5/5 days deployed!

@AndrewGable
Copy link
Contributor

:shipit:

@OSBotify OSBotify reopened this May 20, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@mvtglobally
Copy link

OMG. you are Amazing @AndrewGable. Team will be ecstatic for sure!

@AndrewGable
Copy link
Contributor

Oh oops I missed #8832 - Can you let me know when that's all wrapped up? Thanks!

@mvtglobally
Copy link

@AndrewGable All pass. We are good

@AndrewGable
Copy link
Contributor

:shipit:

@mvtglobally
Copy link

@AndrewGable Dont see a new checklist. Did deploy go through?

@AndrewGable
Copy link
Contributor

Nope - It failed, working on a fix now.

@Stutikuls
Copy link

Stutikuls commented May 26, 2022

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9083
Logged Issues - #8618, #8485, #8618, #8654, #8575, #8403, #8402, #8401, #8633, #8703, #8624, #8480, #9145, #8524, #8481, #8624, #8382, #8555, #8527, #8388, #8387, #8480, #8624, #8651, #8433, #8432, #8671, #8555, #8524, #8577, #8485, #8530, #8480, #8624, #8433, #8432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants