Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify growl is ready #9070

Merged
merged 2 commits into from
May 18, 2022
Merged

Simplify growl is ready #9070

merged 2 commits into from
May 18, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 18, 2022

Details

This was something I saw in the code which could be simplified

Fixed Issues

None

Tests / QA

  1. Edit your personal preferences to change your first or last name
  2. Verify that a growl is displayed

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@tgolen tgolen self-assigned this May 18, 2022
@tgolen tgolen marked this pull request as ready for review May 18, 2022 17:14
@tgolen tgolen requested a review from a team as a code owner May 18, 2022 17:14
@melvin-bot melvin-bot bot requested review from ctkochan22 and removed request for a team May 18, 2022 17:14
Copy link

@ctkochan22 ctkochan22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

@ctkochan22 ctkochan22 merged commit d84f9ce into main May 18, 2022
@ctkochan22 ctkochan22 deleted the tgolen-onready branch May 18, 2022 19:48
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @ctkochan22 in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants