Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable env errors for validate github actions #9572

Closed
chiragsalian opened this issue Jun 27, 2022 · 4 comments
Closed

Fix undefined variable env errors for validate github actions #9572

chiragsalian opened this issue Jun 27, 2022 · 4 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@chiragsalian
Copy link
Contributor

Problem

GH actions is failed on PRs for Validate Github Actions / verify (pull_request)
The error is,

workflows/platformDeploy.yml:94:24: undefined variable "env". available variables are "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy" [expression]
   |
94 |           VERSION: ${{ env.VERSION_CODE }}
   |                        ^~~~~~~~~~~~~~~~
workflows/platformDeploy.yml:255:24: undefined variable "env". available variables are "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy" [expression]
    |
255 |           VERSION: ${{ env.IOS_VERSION }}
    |                        ^~~~~~~~~~~~~~~

Its currently blocking App PRs from being merged.

Solution

Investigate and Fix

@chiragsalian chiragsalian added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Jun 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2022

Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 27, 2022
@chiragsalian
Copy link
Contributor Author

Discussing in slack.

@AndrewGable
Copy link
Contributor

I think this might be a regression from the discussion in rhysd/actionlint#158 ?

@AndrewGable
Copy link
Contributor

We can revert to a known version that works until we get a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants