false negative on use env in env definition

[kazuk]

this commit passes actionlint

kazuk/sbom-ghr@fe18f2d

but The workflow is not valid. shown as bellow.

The workflow is not valid. .github/workflows/rust.yml (Line: 18, Col: 18): Unrecognized named-value: 'env'. Located at position 1 within expression: env.KEY_PREFIX .github/workflows/rust.yml (Line: 43, Col: 22): Unrecognized named-value: 'env'. Located at position 1 within expression: env.KEY_PREFIX

[rhysd]

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#env

Variables in the env map cannot be defined in terms of other variables in the map.

Official document mentioned this limitation here.

https://docs.github.com/en/actions/learn-github-actions/contexts#env-context

You can use the env context in the value of any key in a step except for the id and uses keys.

id and uses also seem to ban env context.

[rhysd]

Now workflow like below

on: push

jobs:
  my_job:
    runs-on: ubuntu-latest
    env:
      FOO: aaa
    steps:
      - uses: test/${{ env.FOO }}@main
        env:
          BAR: ${{ env.FOO }}
        id: foo-${{ env.FOO }}

causes errors as follows:

test.yaml:9:24: undefined variable "env". available variables are "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy" [expression]
  |
9 |       - uses: test/${{ env.FOO }}@main
  |                        ^~~~~~~
test.yaml:11:20: undefined variable "env". available variables are "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy" [expression]
   |
11 |           BAR: ${{ env.FOO }}
   |                    ^~~~~~~
test.yaml:12:21: undefined variable "env". available variables are "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy" [expression]
   |
12 |         id: foo-${{ env.FOO }}
   |                     ^~~~~~~

[rhysd]

This fix was included in the latest release v1.6.14.

[MatthewRyanRead]

On v1.6.14 I am seeing a lot of errors around uses of env.SOMETHING. It seems to be cases where the variables may be defined/injected on a custom runner and aren't runner defaults or initialized earlier in the workflow.

[rhysd]

@MatthewRyanRead Do you mean referring env context in env: is allowed when it is run on self-hosted runner? Could you show the link to the actual workflow if it is public?

[guidojw]

Since these changes, I am experiencing a problem accessing top-level env in a job step's env.

Commit: csvalpha/sofia@51db186

The job configuration worked before, so this new error seems to be incorrect.

[wwalser]

I too was referencing env.GITHUB_SHA in the end: declarations of an individual task. That is now reporting as invalid.

[AndrewGable]

We are also seeing a new error reported on a previously "passing" workflow file.

Failing run: https://github.com/Expensify/App/runs/7078764707?check_suite_focus=true

Workflow file: https://github.com/Expensify/App/blob/main/.github/workflows/platformDeploy.yml

[guidojw]

@rhysd Is this on your radar or should I open a new issue for it?

[rhysd]

Thank you for the information.

I understood what is wrong.

• env: at job level and top level do not allow to refer env context
• but env: at step level allows

I'll fix this and soon release 1.6.15

[rhysd]

I added the fix at 323ceb4.

[rhysd]

The fix was released with v1.6.15.