[HOLD][$4000] "New Password" field is partially hidden by the keyboard popping up

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: user has password suggestion in her/his phone

1. Go to staging.new.expensify.com
2. Log in with any account
3. Go to Setting - Security
4. Put Incorrect password on Current Password field
5. Tap on New password field

Expected Result:

User is able to see a new Password field

Actual Result:

New Password field is partially hidden by Save button

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Please click here to see a recent video of the bug.

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[stitesExpensify]

It looks like the problem is actually the keyboard popping up, not the password suggestions (it's hidden behind the suggestions here). Looks like we need a <keyboardAvoidingView> somewhere. Should be an easy fix

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted:

• Internal: https://www.upwork.com/ab/applicants/1542366198684119040/job-details
• External: https://www.upwork.com/jobs/~01276b1b1746a62a00

I tested this on Android (same version) and it wasn't an issue for me, so perhaps it might be affecting iOS?

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[muaazsheikh]

it will be work we need to more changes in parent view using flex

[jliexpensify]

@muaazsheikh - please feel free to submit a proposal for review!

[muaazsheikh]

@jliexpensify - i already did can you please review it.

[jliexpensify]

@muaazsheikh - it looks like you made a proposal in your Cover Letter in Upworks.

Can you share your proposal within this GH instead? Our process is to have contributors post proposals in the GH for review by our team. Thanks in advance!

[Santhosh-Sellavel]

Waiting for proposal here

[muaazsheikh]

@jliexpensify
There is muliple Ways to handle button upside over keyboard there is a way to make whole screen is KeyboardAvoidingview or one more third party in react native which is KeyboardAwareScrollView if both will not work then we can manage through flex, i was facing this issue number of times but yeah it can be handled.

[Santhosh-Sellavel]

@muaazsheikh

Can you elaborate more and write a detailed/informative on the code changes you are proposing.

Look through these past issues to get an idea about how we expect proposals.

If you haven’t already, check out our contributing guidelines first!

Thanks!

[damdafayton]

@kbecciv @jliexpensify, @Santhosh-Sellavel I think its bad css. Probably save button is positioned absolute/relative to the bottom and keyboard is pushing it up.

[damdafayton]

I have noticed that all elements have the same class name. So I cant pinpoint to the fix. Its about positioning as you can see in the gif.

[shawnborton]

Nice catch with the keyboard!

[Santhosh-Sellavel]

@stitesExpensify
I am happy to move forward with @ntdiary's proposal of migrating to Form!

"New Password save button is partially covered by keyboard".

This would be a common issue that would be occurring only in mWeb, it's common to all the forms that should be a separate issue. Also, I believe it would be handled here

Regarding the keyboard flickering issue, it should be a separate issue.

C+ Reviewed
🎀 👀 🎀
cc: @shawnborton

[stitesExpensify]

Hm so we've been talking about a lot of these things internally because these issues have been popping up so much. @roryabraham is this another one you think should be held for now?

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mallenexpensify]

We're putting all keyboard-related issues on hold for a bit while we discuss a more holistic approach to fixing them (also #9542 and #9252).

@ntdiary it's clear you've invested a lot of time into this issue, your proposal is extremely thorough and well-outlined. You will be compensated for your work, before discussing the amount, we want to see if the best path forward is for you to complete the issue. If so, we'd take off hold then you'd finish then get compensated 7 days after the PR hits production, assuming no regressions. We're discussing next steps internally and will have another update on the hold timeline soon (hopefully tomorrow)

[kadiealexander]

@mallenexpensify any update on your post above?

[stitesExpensify]

Bump :)

[roryabraham]

I think @tgolen has started working on the keyboard-related bugs and improvements tracking issue.

[shawnborton]

Not overdue

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[kadiealexander]

@stitesExpensify @MonilBhavsar Both applause and I are unable to reproduce this, and it's been on hold forever. Do you think we should close it for now?

[tgolen]

I think we should just close this, yes.

[stitesExpensify]

Yep! Closing it out.