Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment - Add payment method button is misaligned #9838

Closed
kbecciv opened this issue Jul 12, 2022 · 6 comments
Closed

Payment - Add payment method button is misaligned #9838

kbecciv opened this issue Jul 12, 2022 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jul 12, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Go Settings -Payments

Expected Result:

Add payment button is not misaligned

Actual Result:

Add payment button is misaligned

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.82.5

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
AddPayment
Prod

Expensify/Expensify Issue URL:

Issue reported by: @mdneyazahmad & Applause - Interna Team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657623654999409

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 12, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2022

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title Payment - Add payment button is misaligned Payment - Add payment method button is misaligned Jul 12, 2022
@roryabraham
Copy link
Contributor

This is a pretty subtle visual bug that doesn't affect the app's usability. I don't think we should block deploy on this.

@AndrewGable
Copy link
Contributor

Agree

@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 12, 2022
@parasharrajat
Copy link
Member

Note: Do test other screens as well. I think that this issue also affects them. Regression from #9665.

It would be better to list down those pages and fix them all in this issue.
For example

  1. Extra margin under the button on RequestCallPage.
    image

@ctkochan22 ctkochan22 added the Improvement Item broken or needs improvement. label Jul 12, 2022
@ctkochan22
Copy link

@Justicea83 do you mind if I steal this from you? This is a result of my own PR #9665

@ctkochan22 ctkochan22 assigned ctkochan22 and unassigned Justicea83 Jul 12, 2022
@ctkochan22 ctkochan22 added the Reviewing Has a PR in review label Jul 12, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants