Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-07-07 #9781

Closed
roryabraham opened this issue Jul 8, 2022 · 19 comments
Closed

Deploy Checklist: New Expensify 2022-07-07 #9781

roryabraham opened this issue Jul 8, 2022 · 19 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jul 8, 2022 •
edited by AndrewGable
Loading

Release Version: 1.1.82-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@roryabraham
Copy link
Contributor Author

Please keep this unlocked for a bit

@mvtglobally
Copy link

@roryabraham tag us when it's good to lock it. It's already late, we will start regression in the morning

@roryabraham
Copy link
Contributor Author

@Expensify/applauseleads You can lock this whenever you're ready 🙇

@roryabraham
Copy link
Contributor Author

roryabraham commented Jul 8, 2022 •
edited
Loading

Verified that #9786 was resolved by #9785, checking both off. I'll also check off #9738 for now because it's been reverted.

@roryabraham
Copy link
Contributor Author

Checked off #9732 because it's not a blocker, but it appears electron-log maybe hasn't been working since March? That's the most recent log I'm seeing in ~/Library/Logs/new.expensify/main.log

@roryabraham
Copy link
Contributor Author

Also there's a bunch of PRs that were already deployed to production included in this checklist. Going to check them off and hope that it's a one-off error resulting from the deploy woes earlier today / me having to manually create this checklist.

@roryabraham
Copy link
Contributor Author

Checking off #9750 because it was fixed by #9783. You can verify that it's working on staging by going to https://staging.new.expensify.com/docs/index.html

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.82-5 🚀

@mvtglobally
Copy link

Regression is completed. Will share summary in a bit

@mvtglobally
Copy link

@AndrewGable

PR #9385 one tester was able to repro #8641 (comment). Since its existing issue, checking off.
PR #9501 is failing #9805. Repro in PROD checking off
PR #9627 & #9650 is failing #9802. Potential blocker. Pls double check
PR #9649 - @arosiclair @Justicea83 Can you check this off?
PR #9665 is pending clarification #9665 (comment)

Issues logged
#9742
#9741
#9747
#9766
#9802
#9805
#9807
#9808
#9809
#9816
#9817
#9827

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 11, 2022
@mvtglobally
Copy link

@AndrewGable just checking if we need to do anything to try and push this checklist today

@AndrewGable
Copy link
Contributor

No, I am working on getting all the internal QA items checked off

@mvtglobally
Copy link

checking off #9665 https://expensify.slack.com/archives/C9YU7BX5M/p1657649041410549

@AndrewGable
Copy link
Contributor

@mvtglobally - Were you able to test #9627 ?

@mvtglobally
Copy link

@AndrewGable Yes, The only issue is #9802. I think we can check it off as thats expected

@AndrewGable
Copy link
Contributor

:shipit:

@AndrewGable AndrewGable reopened this Jul 12, 2022
@AndrewGable
Copy link
Contributor

Deploy did not work, we are looking into it

@roryabraham
Copy link
Contributor Author

Closing this again

@roryabraham
Copy link
Contributor Author

New checklist is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AndrewGable @applausebot @mvtglobally @roryabraham @OSBotify