Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix off-by-one error in scrollToIndex" #9690

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

roryabraham
Copy link
Contributor

Straight revert of #9674

@roryabraham roryabraham requested a review from marcaaron as a code owner July 3, 2022 16:56
@roryabraham roryabraham self-assigned this Jul 3, 2022
@roryabraham roryabraham requested a review from NikkiWines July 3, 2022 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Julesssss
Copy link
Contributor

Merged to resolve this blocker.

@Julesssss Julesssss merged commit 6ebe68d into main Jul 4, 2022
@Julesssss Julesssss deleted the revert-9674-Rory-FixScrollToIndex branch July 4, 2022 10:45
OSBotify pushed a commit that referenced this pull request Jul 4, 2022
…ndex

Revert "Fix off-by-one error in scrollToIndex"

(cherry picked from commit 6ebe68d)
OSBotify added a commit that referenced this pull request Jul 4, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants