Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrowKeyFocusManager for lists with only two options #9682

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix ArrowKeyFocusManager for lists with only two options #9682

merged 1 commit into from
Jul 5, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Fixes the ArrowKeyFocusManager for any list with only two options.

Fixed Issues

$ #9678

Tests / QA Steps

  1. Open the search page, new group page, IOU currency selector, or any other page that uses an OptionSelector
  2. Edit the search query such that there's only two options in the list.
  3. Verify that the arrow keys work as expected to highlight options.
  • Verify that no errors appear in the JS console

@roryabraham roryabraham requested a review from a team as a code owner July 1, 2022 23:18
@roryabraham roryabraham self-assigned this Jul 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team July 1, 2022 23:18
@roryabraham
Copy link
Contributor Author

Added the CP Staging label because this fixes a bug introduced in the current staging release.

@roryabraham roryabraham mentioned this pull request Jul 1, 2022
Closed
@amyevans amyevans merged commit 5ad8542 into main Jul 5, 2022
@amyevans amyevans deleted the Rory-FixArrowNavigatorWithTwoOptions branch July 5, 2022 15:53
OSBotify pushed a commit that referenced this pull request Jul 5, 2022
@amyevans @OSBotify
Merge pull request #9682 from Expensify/Rory-FixArrowNavigatorWithTwo…
3ec40a9 
…Options

Fix ArrowKeyFocusManager for lists with only two options

(cherry picked from commit 5ad8542)
@OSBotify OSBotify mentioned this pull request Jul 5, 2022
Merged
OSBotify added a commit that referenced this pull request Jul 5, 2022
@OSBotify
Merge pull request #9700 from Expensify/OSBotify-cherry-pick-staging-…
a50aa84 
…9682

🍒 Cherry pick PR #9682 to staging 🍒
This was referenced Jul 5, 2022
Closed
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyevans amyevans amyevans approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @amyevans