[No QA] Continue merge without requiring editor #9775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In the local testing of #9771 the editor was required to finish the merge commit. I thought that this wouldn't happen in the GH runner because they have pager disabled by default, but I was wrong. This PR makes it so that, even testing locally, the editor is not required to finish the merge commit.
Fixed Issues
$ n/a – broken deploys.
Local Tests
Go to the App repo locally and run these commands:
Verify that the merge in the last command succeeds and that it DOES NOT open an editor and prompt you for a commit message.
Live Tests