[No QA] Add documentation about error onyx best practice under API.md #9629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
neil-marcellini
and removed request for
a team
luacmartins
previously approved these changes
Jun 29, 2022
iwiznia
previously approved these changes
Jun 29, 2022
Co-authored-by: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com>
aldo-expensify
previously approved these changes
Jun 29, 2022
iwiznia
previously approved these changes
Jun 29, 2022
luacmartins
previously approved these changes
Jun 29, 2022
robertjchen
requested changes
Jun 30, 2022
MariaHCD
reviewed
Jun 30, 2022
Co-authored-by: Robert Chen <robert@expensify.com>
yuwenmemon
dismissed stale reviews from luacmartins, iwiznia, and aldo-expensify
via
cc49970
Co-authored-by: Maria D'Costa <maria@expensify.com>
MariaHCD
approved these changes
Jun 30, 2022
robertjchen
approved these changes
Jun 30, 2022
nkuoch
approved these changes
Jun 30, 2022
Julesssss
approved these changes
Jun 30, 2022
neil-marcellini
approved these changes
Jun 30, 2022
aldo-expensify
approved these changes
Jun 30, 2022
luacmartins
approved these changes
Jun 30, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.81-0 🚀
|
roryabraham
changed the title
|
🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pullerbearing (@neil-marcellini)
cc @nkuoch @marcaaron @tgolen @iwiznia @Julesssss @MariaHCD @aldo-expensify @luacmartins
Details
Adding what was discussed in this thread about errors returned and stored in Onyx being stored under
errorFixed Issues
None
Tests
None