Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Run lint and test jobs in parallel #9611

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Conversation

roryabraham
Copy link
Contributor

Details

This PR uses a new(ish) GitHub Actions features: reusable workflows. Before we had a hacky workaround in place – a custom action called triggerWorkflowAndWait. By using the native feature we get a better dependency graph, more concise and transparent workflow syntax, and also get to run multiple reusable workflows in parallel, if we want.

Fixed Issues

$ n/a, doing some exploratory/prep work for https://github.com/Expensify/Expensify/issues/195693

Tests

Did some testing over in https://github.com/Andrew-Test-Org/Public-Test-Repo/pull/300.

QA Steps

  1. Merge this PR, the preDeploy workflow should run lint and test in parallel.
  2. Merge another PR with purposely failing lint.
  3. We should get alerted in slack that the preDeploy workflow failed.
  4. Merge another PR to revert the purposely failing lint.

@roryabraham roryabraham requested a review from AndrewGable June 28, 2022 20:15
@roryabraham roryabraham requested a review from a team as a code owner June 28, 2022 20:15
@roryabraham roryabraham self-assigned this Jun 28, 2022
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team June 28, 2022 20:15
@roryabraham roryabraham merged commit 7da6439 into main Jun 28, 2022
@roryabraham roryabraham deleted the Rory-CallableWorkflow branch June 28, 2022 20:48
@roryabraham
Copy link
Contributor Author

Nice dependency graph:

image

@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@roryabraham roryabraham changed the title Run lint and test jobs in parallel [No QA] Run lint and test jobs in parallel Jul 8, 2022
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants