-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SettlementButton/KYCWall #10193
Conversation
I need to add clear test steps, and update "OpenPaymentsPage" to a more generic command now that I want to use it for KYC |
src/pages/iou/IOUDetailsModal.js
Outdated
@@ -150,6 +151,7 @@ class IOUDetailsModal extends Component { | |||
))} | |||
</View> | |||
)} | |||
<OfflineIndicator containerStyles={[styles.ml5, styles.mb2]} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but I think this might not be needed now that we added a global offline indicator with this PR. Does this not duplicate that indicator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It strangely wasn't covered. IOUModal
was covered but not the details page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the duplicate OfflineIndicator, LGTM!
Updated! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
cc @MariaHCD
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/216153
Tests
We are testing the functionality of the KYCWall, which determines if there is any step a user needs to take before completing an action.
Setup:
Test & confirm the outcome of pressing "Pay with Expensify"
- User 1 with no payment method sees option to add payment method
- User 2 with debit card payment method and User 3 with personal bank account, both with no kyc. Sees the additional information modal pop up
- User 4 with kyc filled, moves forward and you are able to settle up
Test and confirm the Transfer button
The sender should now have an amount after user 4 paid them successfully.
user_good
andpass_good
. Click transfer again and verify that you see the "Additional Details" modalOffline behavior
You can mock offline by going into the console, selecting "Network", setting "No throttling" to offline
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
You will need to test by requesting amount from several types of users:
First request an amount from all three users. As the user, navigate to the report, then click on "Pay". This should open a detailed IOU modal. Please click "Pay with Expensify" and confirm the following:
ctseng+debitqa@expensifail.com
with passwordPassword1
. It has a live debit account, but no KYC set up.