Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call listenForReconnect on App init #10314

Merged
merged 6 commits into from
Aug 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Expensify.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import ConfirmModal from './components/ConfirmModal';
import compose from './libs/compose';
import withLocalize, {withLocalizePropTypes} from './components/withLocalize';
import * as User from './libs/actions/User';
import NetworkConnection from './libs/NetworkConnection';

Onyx.registerLogger(({level, message}) => {
if (level === 'alert') {
Expand Down Expand Up @@ -91,6 +92,9 @@ class Expensify extends PureComponent {
isOnyxMigrated: false,
isSplashShown: true,
};

// Used for the offline indicator appearing when someone is offline
NetworkConnection.subscribeToNetInfo();
}

componentDidMount() {
Expand Down
4 changes: 4 additions & 0 deletions src/libs/Navigation/AppNavigator/AuthScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ class AuthScreens extends React.Component {

componentDidMount() {
NetworkConnection.listenForReconnect();
NetworkConnection.onReconnect(() => {
App.getAppData();
App.reconnectApp();
});
PusherConnectionManager.init();
Pusher.init({
appKey: CONFIG.PUSHER.APP_KEY,
Expand Down
3 changes: 1 addition & 2 deletions src/libs/NetworkConnection.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ function listenForReconnect() {
unsubscribeFromAppState = AppStateMonitor.addBecameActiveListener(() => {
triggerReconnectionCallbacks('app became active');
});

subscribeToNetInfo();
}

/**
Expand Down Expand Up @@ -130,4 +128,5 @@ export default {
onReconnect,
triggerReconnectionCallbacks,
recheckNetworkConnection,
subscribeToNetInfo,
};
8 changes: 1 addition & 7 deletions src/libs/actions/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import Timing from './Timing';
import * as Report from './Report';
import * as BankAccounts from './BankAccounts';
import * as Policy from './Policy';
import NetworkConnection from '../NetworkConnection';
import Navigation from '../Navigation/Navigation';
import ROUTES from '../../ROUTES';
import * as SessionUtils from '../SessionUtils';
Expand Down Expand Up @@ -251,12 +250,6 @@ function openProfile() {
Navigation.navigate(ROUTES.SETTINGS_PROFILE);
}

// When the app reconnects from being offline, fetch all initialization data
NetworkConnection.onReconnect(() => {
getAppData();
reconnectApp();
});

export {
setLocale,
setSidebarLoaded,
Expand All @@ -265,4 +258,5 @@ export {
setUpPoliciesAndNavigate,
openProfile,
openApp,
reconnectApp,
};
10 changes: 10 additions & 0 deletions src/libs/actions/SignInRedirect.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,19 @@ Onyx.connect({
callback: val => currentPreferredLocale = val,
});

let currentIsOffline;
luacmartins marked this conversation as resolved.
Show resolved Hide resolved
Onyx.connect({
key: ONYXKEYS.NETWORK,
callback: val => currentIsOffline = val.isOffline,
});

/**
* @param {String} errorMessage
*/
function clearStorageAndRedirect(errorMessage) {
const activeClients = currentActiveClients;
const preferredLocale = currentPreferredLocale;
const isOffline = currentIsOffline;
luacmartins marked this conversation as resolved.
Show resolved Hide resolved

// Clearing storage discards the authToken. This causes a redirect to the SignIn screen
Onyx.clear()
Expand All @@ -32,6 +39,9 @@ function clearStorageAndRedirect(errorMessage) {
if (activeClients && activeClients.length > 0) {
Onyx.set(ONYXKEYS.ACTIVE_CLIENTS, activeClients);
}
if (isOffline) {
Onyx.set(ONYXKEYS.NETWORK, {isOffline});
}

// `Onyx.clear` reinitialize the Onyx instance with initial values so use `Onyx.merge` instead of `Onyx.set`.
Onyx.merge(ONYXKEYS.SESSION, {error: errorMessage});
Expand Down
12 changes: 12 additions & 0 deletions src/pages/signin/LoginForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ import * as ValidationUtils from '../../libs/ValidationUtils';
import * as LoginUtils from '../../libs/LoginUtils';
import withToggleVisibilityView, {toggleVisibilityViewPropTypes} from '../../components/withToggleVisibilityView';
import FormAlertWithSubmitButton from '../../components/FormAlertWithSubmitButton';
import OfflineIndicator from '../../components/OfflineIndicator';
import {withNetwork} from '../../components/OnyxProvider';
import networkPropTypes from '../../components/networkPropTypes';

const propTypes = {
/** Should we dismiss the keyboard when transitioning away from the page? */
Expand All @@ -37,6 +40,9 @@ const propTypes = {
isLoading: PropTypes.bool,
}),

/** Props to detect online status */
network: networkPropTypes.isRequired,

...windowDimensionsPropTypes,

...withLocalizePropTypes,
Expand Down Expand Up @@ -113,6 +119,10 @@ class LoginForm extends React.Component {
* Check that all the form fields are valid, then trigger the submit callback
*/
validateAndSubmitForm() {
if (this.props.network.isOffline) {
return;
}

const login = this.state.login.trim();
if (!login) {
this.setState({formError: 'common.pleaseEnterEmailOrPhoneNumber'});
Expand Down Expand Up @@ -181,6 +191,7 @@ class LoginForm extends React.Component {
containerStyles={[styles.mh0]}
/>
</View>
<OfflineIndicator containerStyles={[styles.mv1]} />
</>
);
}
Expand All @@ -196,4 +207,5 @@ export default compose(
withWindowDimensions,
withLocalize,
withToggleVisibilityView,
withNetwork(),
)(LoginForm);