Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 16 and npm 8 via nvm and updated many node packages #10439

Merged
merged 17 commits into from
Aug 19, 2022
Merged

Update to node 16 and npm 8 via nvm and updated many node packages #10439

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c59b3cb
Update to node 16 and npm 8
AndrewGable Aug 17, 2022
d374f29
Fix tests
AndrewGable Aug 18, 2022
cefecae
Try to use v3
AndrewGable Aug 18, 2022
446d607
Try to use 16 string to test
AndrewGable Aug 18, 2022
65a8ce0
Update to use correct version
AndrewGable Aug 18, 2022
d672709
Add `eslint-plugin-jsx-a11y`
AndrewGable Aug 18, 2022
02516b0
Rebuild actions
AndrewGable Aug 18, 2022
fc40d5e
Tweak where eslint checks
AndrewGable Aug 18, 2022
454b8bb
Merge branch 'main' into andrew-npm-8
AndrewGable Aug 18, 2022
b221450
Use forked and published package with node support
AndrewGable Aug 18, 2022
8a3fae0
Merge branch 'main' into andrew-npm-8
AndrewGable Aug 18, 2022
d1da6e5
Rebuild actions
AndrewGable Aug 18, 2022
735d9c6
Fix test
AndrewGable Aug 18, 2022
aaa8b14
Use Expensify fork for `@onfido/react-native-sdk`
AndrewGable Aug 18, 2022
27a6de9
Update iOS
AndrewGable Aug 18, 2022
c2186d2
Update README with change to nvm/npm/node
AndrewGable Aug 18, 2022
2be58c1
Make wording more clear
AndrewGable Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/composite/setupNode/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ runs:

- uses: actions/setup-node@09ba51f18e18a3756fea1f54d09c6745c064491d
with:
node-version: 14.19.3
node-version-file: '.nvmrc'
cache: npm

- name: Install node packages
Expand Down
21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/awaitStagingDeploys/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2,643 changes: 2,364 additions & 279 deletions .github/actions/javascript/bumpVersion/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2,273 changes: 2,183 additions & 90 deletions .github/actions/javascript/checkBundleVersionStringMatch/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/checkDeployBlockers/index.js
View file
Open in desktop

Large diffs are not rendered by default.

30,573 changes: 15,802 additions & 14,771 deletions .github/actions/javascript/createOrUpdateStagingDeploy/index.js
View file
Open in desktop

Large diffs are not rendered by default.

5,065 changes: 3,048 additions & 2,017 deletions .github/actions/javascript/getDeployPullRequestList/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/getPullRequestDetails/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/getReleaseBody/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/isPullRequestMergeable/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/isStagingDeployLocked/index.js
View file
Open in desktop

Large diffs are not rendered by default.

20,903 changes: 10,967 additions & 9,936 deletions .github/actions/javascript/markPullRequestsAsDeployed/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/reopenIssueWithComment/index.js
View file
Open in desktop

Large diffs are not rendered by default.

21,045 changes: 11,038 additions & 10,007 deletions .github/actions/javascript/triggerWorkflowAndWait/index.js
View file
Open in desktop

Large diffs are not rendered by default.

20,903 changes: 10,967 additions & 9,936 deletions .github/actions/javascript/verifySignedCommits/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }}
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- run: npm run lint
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
if: ${{ fromJSON(needs.validateActor.outputs.IS_DEPLOYER) }}
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8
AndrewGable marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using the local file https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-an-action-in-the-same-repository-as-the-workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that we want to lock it to a branch, but we cannot lock it to main until this PR is merged. Using local files would work, but it wouldn't lock it to a commit.

Copy link
Member

@parasharrajat parasharrajat Aug 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would say lock to a commit instead of the branch name. But I got it.


- uses: ruby/setup-ruby@08245253a76fa4d1e459b7809579c62bd9eb718a
with:
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
if: ${{ fromJSON(needs.validateActor.outputs.IS_DEPLOYER) }}
runs-on: macos-11
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- name: Decrypt Developer ID Certificate
run: cd desktop && gpg --quiet --batch --yes --decrypt --passphrase="$DEVELOPER_ID_SECRET_PASSPHRASE" --output developer_id.p12 developer_id.p12.gpg
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
if: ${{ fromJSON(needs.validateActor.outputs.IS_DEPLOYER) }}
runs-on: macos-11
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- uses: ruby/setup-ruby@08245253a76fa4d1e459b7809579c62bd9eb718a
with:
Expand Down Expand Up @@ -208,7 +208,7 @@ jobs:
if: ${{ fromJSON(needs.validateActor.outputs.IS_DEPLOYER) }}
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- name: Setup python
run: sudo apt-get install python3-setuptools
Expand Down Expand Up @@ -336,7 +336,7 @@ jobs:
if: ${{ always() }}
needs: [android, desktop, iOS, web]
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- name: Set version
run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }}
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

# If automatic signing is enabled, iOS builds will fail, so ensure we always have the proper profile specified
- name: Check Provisioning Style
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validateGithubActions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
if: github.actor != 'OSBotify'
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

# Rebuild all the actions on this branch and check for a diff. Fail if there is one,
# because that would be a sign that the PR author did not rebuild the Github Actions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verifyPodfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
if: github.actor != 'OSBotify'
runs-on: ubuntu-latest
steps:
- uses: Expensify/App/.github/actions/composite/setupNode@main
- uses: Expensify/App/.github/actions/composite/setupNode@andrew-npm-8

- run: ./.github/scripts/verifyPodfile.sh
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16.15.1
Loading