Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the usage of IS_CREATING_WORKSPACE #10600

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Remove the usage of IS_CREATING_WORKSPACE #10600

merged 3 commits into from
Aug 29, 2022

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Aug 26, 2022 •
edited
Loading

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/224685

Tests

Tests & QA Steps

  1. Click ➕ new button
  2. Select the New workspace option
  3. Now quickly (before the Workspace creation notification shows) click ➕ again
  4. New workspace option should still be available until the workspace is actually created

Tested On

  • Web
  • Desktop
  • iOS
  • Android
  • Mobile Web

@Gonals Gonals self-assigned this Aug 26, 2022
@Gonals Gonals requested a review from a team as a code owner August 26, 2022 15:16
@melvin-bot melvin-bot bot requested review from Justicea83 and removed request for a team August 26, 2022 15:17
@Gonals Gonals requested a review from thienlnam August 26, 2022 15:44
@Gonals Gonals changed the title [WIP] Remove the usage of IS_CREATING_WORKSPACE Remove the usage of IS_CREATING_WORKSPACE Aug 26, 2022
@Gonals
Copy link
Contributor Author

Gonals commented Aug 26, 2022

OFF WIP!

thienlnam
thienlnam approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks solid!

@Gonals Gonals requested review from a team and removed request for Justicea83 August 29, 2022 14:26
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team August 29, 2022 14:26
arosiclair
arosiclair approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@arosiclair arosiclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well!

@arosiclair arosiclair merged commit 28c6f43 into main Aug 29, 2022
@arosiclair arosiclair deleted the alberto-removeKey branch August 29, 2022 14:48
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 30, 2022
Closed
11 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @arosiclair in version: 1.1.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

@arosiclair arosiclair arosiclair approved these changes

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gonals @OSBotify @arosiclair @thienlnam