Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus to the 2FA field once password is successful #10603

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

johnmlee101
Copy link
Contributor

@johnmlee101 johnmlee101 commented Aug 26, 2022

Details

When the 2FA pop up shows up (the account has 2fa enabled), this changes the focus from the password field to the 2FA field.

Fixed Issues

$ #10601

Tests and QA steps

  • Sign into an account on the sign in page without 2fa enabled and see success and no focus-changing abnormal behaviors (focus stays on the active field)
  • Sign into an account on the sign in page with 2fa and see that the 2fa field is focused on when it first appears, not in any other flow.
    • Go to URL https://staging.new.expensify.com/
    • In the log in screen enter an account that has 2FA enabled
    • Enter the correct password in the password field and press "Enter" key in the keyboard
    • See that the 2FA field is focused on for new text

Uploading Screen Recording 2022-08-29 at 10.27.13 AM.mov…

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Desktop
  • iOS
  • Android
  • Mobile Web

@johnmlee101 johnmlee101 self-assigned this Aug 26, 2022
@johnmlee101 johnmlee101 marked this pull request as ready for review August 29, 2022 09:10
@johnmlee101 johnmlee101 requested a review from a team as a code owner August 29, 2022 09:10
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team August 29, 2022 09:10
@cristipaval cristipaval merged commit d1ccecd into main Aug 30, 2022
@cristipaval cristipaval deleted the john-focus-2fa-after-prompt branch August 30, 2022 21:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @cristipaval in version: 1.1.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants