Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workspace chats on delete even if they are pinned #10689

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Aug 30, 2022

Details

Fixed Issues

$ #10355

Tests / QA Steps

  1. Create a new workspace in Newdot if you don't have one:

Screen Shot 2022-08-30 at 3 29 35 PM

  1. It will create some default rooms:

Screen Shot 2022-08-30 at 3 34 55 PM

  1. Choose the Admins or Announce one and pin it. Then, move to a different chat.
  2. Delete the Workspace:

Screen Shot 2022-08-30 at 3 36 01 PM

  1. The Pinned chat should disappear from the list (It may take a refresh, as that list doesn't auto-refresh that often)

@Gonals Gonals self-assigned this Aug 30, 2022
@Gonals Gonals requested a review from a team as a code owner August 30, 2022 13:36
@melvin-bot melvin-bot bot requested review from puneetlath and removed request for a team August 30, 2022 13:37
@Gonals Gonals changed the title Alberto delete workspace Remove workspace chats on delete even if they are pinned Aug 30, 2022
@puneetlath
Copy link
Contributor

@Gonals if this isn't newsletter urgent, I think it'd be a good PR to try out the ContributorPlusReview process to have them test your PR on all devices, etc.

@Gonals
Copy link
Contributor Author

Gonals commented Aug 31, 2022

@Gonals if this isn't newsletter urgent, I think it'd be a good PR to try out the ContributorPlusReview process to have them test your PR on all devices, etc.

Sounds good!

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetlath LGTM! 🎉 seems straightforward and tests well!

PR Reviewer Checklist
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@puneetlath puneetlath merged commit 541f15b into main Sep 1, 2022
@puneetlath puneetlath deleted the alberto-deleteWorkspace branch September 1, 2022 08:13
@melvin-bot melvin-bot bot added the Emergency label Sep 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

@puneetlath looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor

All the tests did pass Melv.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Justicea83
Copy link
Contributor

Is there a way to trigger an event of some sort to cause the chats to refresh instantly after deleting the workspace?

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2022

🚀 Deployed to staging by @puneetlath in version: 1.1.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants