-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup from #10749 #10809
Cleanup from #10749 #10809
Conversation
Hey @puneetlath, I think you'll need to re-add the contributor checklist and check every box before the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but I can't test just yet as I first need to rebuild my vm this morning. I'll get back to this soon.
@puneetlath looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
I'm going to go ahead and merge without the full checklist. Sorry Melv! |
🚀 Deployed to staging by @puneetlath in version: 1.1.97-1 🚀
|
A couple of small cleanup items that @iwiznia pointed out after #10749 was merged.
Tests
Onyx.merge('policy_8C6BF17C3E92D600', {pendingAction: 'add'});
in order to create a pending action on your workspaceQA Steps
This won't be testable on staging/production until https://github.com/Expensify/Expensify/issues/224690 is also live. At that point:
+
button and create a workspaceScreenshots
Web
Mobile Web
Desktop
iOS
Android