Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup from #10749 #10809

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Cleanup from #10749 #10809

merged 2 commits into from
Sep 5, 2022

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Sep 5, 2022

A couple of small cleanup items that @iwiznia pointed out after #10749 was merged.

Tests

  1. In the console do Onyx.merge('policy_8C6BF17C3E92D600', {pendingAction: 'add'}); in order to create a pending action on your workspace
  2. In the Network tab, set yourself offline
  3. Click your profile picture to get to the settings page
  4. The row for the Workspace should be grayed out
  5. Click into the workspace
  6. The whole page should be grayed out
  • Verify that no errors appear in the JS console

QA Steps

This won't be testable on staging/production until https://github.com/Expensify/Expensify/issues/224690 is also live. At that point:

  1. Open the app, then go offline
  2. Click the + button and create a workspace
  3. Click your profile picture to go the Settings page
  4. Check that the row in settings for the Workspace is grayed out
  5. Click/tap into the workspace
  6. Verify that the full workspace settings page is grayed out
  • Verify that no errors appear in the JS console

Screenshots

Web

Screen Shot 2022-09-02 at 10 12 41 AM

Screen Shot 2022-09-02 at 10 12 49 AM

Mobile Web

Desktop

Screen Shot 2022-09-02 at 10 38 33 AM

Screen Shot 2022-09-02 at 10 38 25 AM

iOS

Android

@puneetlath puneetlath requested a review from iwiznia September 5, 2022 09:46
@puneetlath puneetlath self-assigned this Sep 5, 2022
@puneetlath puneetlath requested a review from a team as a code owner September 5, 2022 09:46
@melvin-bot melvin-bot bot requested review from Julesssss and removed request for a team September 5, 2022 09:46
@Julesssss
Copy link
Contributor

Hey @puneetlath, I think you'll need to re-add the contributor checklist and check every box before the Contributor Checklist check will pass.

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I can't test just yet as I first need to rebuild my vm this morning. I'll get back to this soon.

@puneetlath puneetlath merged commit 449043e into main Sep 5, 2022
@puneetlath puneetlath deleted the workspace-offline-ux branch September 5, 2022 12:38
@melvin-bot melvin-bot bot added the Emergency label Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

@puneetlath looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor Author

I'm going to go ahead and merge without the full checklist. Sorry Melv!

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2022

🚀 Deployed to staging by @puneetlath in version: 1.1.97-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants