-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Fetch full PR object to fix CPs #10856
Conversation
|
@@ -87,9 +87,13 @@ if (pullRequestNumber) { | |||
...DEFAULT_PAYLOAD, | |||
state: 'all', | |||
}) | |||
.then(({data}) => _.find(data, PR => PR.user.login === user && titleRegex.test(PR.title)).number) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about highlighting the case where we fail to get a matching PR with an error
? I think probably not as the logs should be clear enough (like the one we're currently fixing), but thought I'd ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
[No QA] Fetch full PR object to fix CPs (cherry picked from commit 7747acd)
…-10856 🍒 Cherry pick PR #10856 to staging 🍒
🚀 Cherry-picked to staging by @Julesssss in version: 1.1.97-6 🚀
|
🚀 Cherry-picked to staging by @Julesssss in version: 1.1.97-3 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
|
Details
pulls.list
seems to be returning an summary object rather than the full PR. This is a recent breaking change in the GitHub API (or maybe a fluke), but in either event this solution has been tested locally and seems to fix it.Fixed Issues
$ n/a – https://expensify.slack.com/archives/C0421RF2STA/p1662542102350309
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)