-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to workaround a workflow CP edge case #10867
Conversation
|
|
@techievivek looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
…Workflow Attempt to workaround a workflow CP edge case (cherry picked from commit 766870d)
…-10867 🍒 Cherry pick PR #10867 to staging 🍒
🚀 Cherry-picked to staging by @techievivek in version: 1.1.97-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
The deploy is blocked by this issue. This useless change is simply being merged to trigger an automated CP workflow as a workaround to this issue. I'm hoping that this will result in a successful build.
Fixed Issues
https://github.com/Expensify/Expensify/issues/227242
Tests
Contributor Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)