-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form refactor bankaccountstep #10900
Merged
youssef-lr
merged 26 commits into
Expensify:main
from
jayeshmangwani:form_refactor_bankaccountstep
Sep 30, 2022
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c09bf34
bank account step form refactored
jayeshmangwani 3f8c116
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 8808c9c
fixed console warnings & changed inputID defaultValue from undefined …
jayeshmangwani 9bf7312
added shouldSaveDraft to inputs and checkbox
jayeshmangwani 7ecc6c2
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 590d0df
resolved conflicts & replaced form key with REIMBURSEMENT_ACCOUNT key
jayeshmangwani f4134db
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 191739a
added isSubmitButtonVisible form prop
jayeshmangwani 90057a2
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 2d99e38
skipped validation for plaid
jayeshmangwani cdb883a
removed inputID from AddPlaidBankAccount
jayeshmangwani 2ef74ca
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 0e2b26f
added validate function to PLAID Form
jayeshmangwani 4bdc2d7
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 5f08c30
updated onyx key name for bankaccount form
jayeshmangwani df9b2c0
merged & resolved conflicts, accepted incoming changes
jayeshmangwani 84011f1
added form component to BankAccountManualStep & BankAccountPlaidStep
jayeshmangwani e19f42f
updated formID for plaid
jayeshmangwani e8c0496
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 58198e2
merged and resolved conflicts
jayeshmangwani 27dddb3
updated ONYX key name from BANK_FORM to REIMBURSEMENT_ACCOUNT_FORM
jayeshmangwani ebcc540
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani 44cc59d
resolved conflicts
jayeshmangwani fbd3ca4
Merge branch 'main' into form_refactor_bankaccountstep
jayeshmangwani bd2e691
merged code from Form and FormActions
jayeshmangwani 08753f3
fixed newline lint issue
jayeshmangwani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a refactor in #20228 , I got an eslint error related to this line :
I guess this should be updated to
this.props.formState.errors
. But as I don't have much context, I would appreciate further clarification on this issue.cc @jayeshmangwani @luacmartins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this change, I copied these changes from this Form.js file and @youssef-lr may have the full context of these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're removing
this.props.formState.error
from that line in https://github.com/Expensify/App/pull/20091/files. See this comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s perfect.