Fix incorrect webpage title on back button press (chrome bug) #11160

marcaaron · 2022-09-21T07:10:24Z

cc @iwiznia since this bug is really bothering you 😄

Details

This is a workaround for a very annoying bug in the Chrome browser. It is a hack but I am not able to find and alternative and people will not stop complaining about this so it must be done???

Fixed Issues

$ #8005

Tests (Web & Mobile Web Only)

Start a chat between User A and User B
Send a message from User B to User A while User A has the chat OUT OF VIEW
Verify the (1) appears in the document title
Navigate to the chat
Verify there is no count in the document title
Navigate back using the browser back button
Verify the count does not persist in the document title (note: there will be a brief flash of the count - but then it will stay hidden)

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Verify that no errors appear in the JS console

Screenshots

Web

2022-10-04_12-15-08.mp4

Mobile Web - Chrome

2022-10-04_12-25-01.mp4

Mobile Web - Safari

2022-10-04_12-36-04.mp4

Desktop

N/A since there is no document.title on this platform

iOS

N/A since there is no document.title on this platform

Android

N/A since there is no document.title on this platform

marcaaron · 2022-09-21T07:11:59Z

src/libs/UnreadIndicatorUpdater/index.js

 */
 const throttledUpdatePageTitleAndUnreadCount = _.throttle(() => {
    const totalCount = _.filter(reports, ReportUtils.isUnread).length;
    updateUnread(totalCount);
-}, 1000, {leading: false});
+}, 100, {leading: false});


Updated this since 1 second is a pretty long time and we are mainly throttling to avoid quick blasts of reports triggering the update when you maybe have hundreds of them that are getting read from Onyx on app init or something.

Beamanator

Looks good and tests well, hope this solves our problems for a while 🙏

src/libs/UnreadIndicatorUpdater/updateUnread/index.website.js

marcaaron · 2022-10-05T18:14:08Z

I think we'll need someone to post the completed checklist before we can merge.

Beamanator · 2022-10-06T14:57:32Z

Tested on Web & Desktop 👍

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-06T19:14:48Z

@marcaaron looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcaaron · 2022-10-06T19:16:56Z

🤷‍♂️ everything is checked and was good to merge before I clicked the merge button. Can see there are like 4 checklist jobs. Not really sure what is up with that.

OSBotify · 2022-10-06T19:19:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-12T00:06:20Z

🚀 Deployed to staging by @marcaaron in version: 1.2.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-13T05:56:19Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.13-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…leIndicator Fix incorrect webpage title on back button press (chrome bug)

Fix incorrect webpage title on back button press (chrome bug)

321dc8e

marcaaron self-assigned this Sep 21, 2022

marcaaron commented Sep 21, 2022

View reviewed changes

marcaaron mentioned this pull request Oct 3, 2022

[Bug] [$2000] The browser tab shows (1) New Expensify even though there are no unread messages in the LHN #8005

Closed

marcaaron marked this pull request as ready for review October 4, 2022 22:37

marcaaron requested a review from a team as a code owner October 4, 2022 22:37

melvin-bot bot requested review from youssef-lr and removed request for a team October 4, 2022 22:37

Beamanator approved these changes Oct 5, 2022

View reviewed changes

src/libs/UnreadIndicatorUpdater/updateUnread/index.website.js Show resolved Hide resolved

marcaaron merged commit 5df0171 into main Oct 6, 2022

marcaaron deleted the marcaaron-fixWebTitleIndicator branch October 6, 2022 19:14

melvin-bot bot added the Emergency label Oct 6, 2022

marcaaron removed the Emergency label Oct 6, 2022

OSBotify mentioned this pull request Oct 11, 2022

Deploy Checklist: New Expensify 2022-10-11 #11741

Closed

48 tasks

smrutiparida pushed a commit to autosave-app/App that referenced this pull request Oct 13, 2022

Merge pull request Expensify#11160 from Expensify/marcaaron-fixWebTit…

03f3925

…leIndicator Fix incorrect webpage title on back button press (chrome bug)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect webpage title on back button press (chrome bug) #11160

Fix incorrect webpage title on back button press (chrome bug) #11160

marcaaron commented Sep 21, 2022 •

edited

Loading

marcaaron Sep 21, 2022

Beamanator left a comment

marcaaron commented Oct 5, 2022

Beamanator commented Oct 6, 2022 •

edited by marcaaron

Loading

melvin-bot bot commented Oct 6, 2022

marcaaron commented Oct 6, 2022

OSBotify commented Oct 6, 2022

OSBotify commented Oct 12, 2022

OSBotify commented Oct 13, 2022

Fix incorrect webpage title on back button press (chrome bug) #11160

Fix incorrect webpage title on back button press (chrome bug) #11160

Conversation

marcaaron commented Sep 21, 2022 • edited Loading

Details

Fixed Issues

Tests (Web & Mobile Web Only)

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcaaron Sep 21, 2022

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

marcaaron commented Oct 5, 2022

Beamanator commented Oct 6, 2022 • edited by marcaaron Loading

melvin-bot bot commented Oct 6, 2022

marcaaron commented Oct 6, 2022

OSBotify commented Oct 6, 2022

OSBotify commented Oct 12, 2022

OSBotify commented Oct 13, 2022

marcaaron commented Sep 21, 2022 •

edited

Loading

Beamanator commented Oct 6, 2022 •

edited by marcaaron

Loading