fix "Going from small to large screen and vice-versa clears the field for Email/Password input fields" #11304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Email/Password input fields"
melvin-bot
bot
requested review from
puneetlath and
Santhosh-Sellavel
and removed request for
a team
|
Test step could be better!
Resize web/desktop window from large to small screen & vice-versa |
updated |
|
Sorry for the delay here @aimane-chnaif, reviewing this now. |
| } | ||
|
|
||
| return ( | ||
| <View style={[styles.flex1, styles.signInPageInner]}> | ||
| <View style={[styles.flex1, styles.flexRow, styles.flexGrow1]}> |
There was a problem hiding this comment.
Here we have flexGrow1 it's removed in refactored code and won't create any regressions.
There was a problem hiding this comment.
@Santhosh-Sellavel styles.flex1 involves styles.flexGrow1 so redundant
reference: https://stackoverflow.com/questions/35395691/understanding-the-difference-between-the-flex-and-flex-grow-properties
There was a problem hiding this comment.
I removed this because style conflicts and UI broken while going from large to medium screen by decreasing width
|
Santhosh-Sellavel
previously approved these changes
Oct 6, 2022
puneetlath
requested changes
Oct 7, 2022
| containerStyles.push(styles.dFlex, styles.signInPageInner, styles.flexColumnReverse, styles.justifyContentBetween); | ||
| } else { | ||
| containerStyles.push(styles.flex1, styles.signInPageInner); | ||
| contentContainerStyles.push(styles.flexRow); |
There was a problem hiding this comment.
I think rather than pushing variables into the arrays, via an if/elseif/else it would be clearer to set them directly. So something like:
let containerStyles = [styles.flex1, styles.signInPageInner];
let contentContainerStyles = [styles.flex1, styles.flexRow];
if (props.isSmallScreenWidth) {
containerStyles = [styles.flex1];
contentContainerStyles = [styles.flex1];
}
if (isLongMediumScreenWidth) {
containerStyles = [styles.dFlex, styles.signInPageInner, styles.flexColumnReverse, styles.justifyContentBetween];
contentContainerStyles = [styles.flex1];
}
That way it's very easy to see for each screen size, what the containerStyles and contentContainerStyles are.
puneetlath
approved these changes
Oct 7, 2022
|
Looks good to me. I just want to confirm this has been re-tested before merging. |
Santhosh-Sellavel
approved these changes
Oct 7, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 tasks
|
🚀 Deployed to staging by @puneetlath in version: 1.2.13-0 🚀
|
|
🚀 Deployed to production by @yuwenmemon in version: 1.2.13-5 🚀
|
smrutiparida
pushed a commit
to autosave-app/App
that referenced
this pull request
Oct 13, 2022
fix "Going from small to large screen and vice-versa clears the field for Email/Password input fields"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Proposal: #9510 (comment)
Fixed Issues
$ #9510
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps
Screenshots
Web
web.mov
Mobile Web - Chrome
tablet.chrome.mp4
Mobile Web - Safari
ipad.safari.mov
Desktop
desktop.mov
iOS
ipad.mov
Android
tablet.mp4