Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Composer goes to the top on pressing expand" #11608

Merged
merged 6 commits into from
Oct 19, 2022
Merged

fix "Composer goes to the top on pressing expand" #11608

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f742741
fix "Composer goes to the top on pressing expand"
aimane-chnaif Oct 5, 2022
9a643a8
float text to top when composer expanded
aimane-chnaif Oct 10, 2022
1150a97
stretch input to full height in composer when expanded
aimane-chnaif Oct 11, 2022
61e5278
fix invalid prop warning
aimane-chnaif Oct 11, 2022
2070b13
add contentContainerStyle propsTypes in OfflineWithFeedback
aimane-chnaif Oct 12, 2022
bbe4676
fix text centered in expanded composer issue in android
aimane-chnaif Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/OfflineWithFeedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const OfflineWithFeedback = (props) => {
return (
<View style={props.style}>
{!hideChildren && (
<View style={needsOpacity ? styles.offlineFeedback.pending : {}}>
<View style={[needsOpacity ? styles.offlineFeedback.pending : {}, props.contentContainerStyle]}>
{children}
</View>
)}
Expand Down
2 changes: 2 additions & 0 deletions src/pages/home/report/ReportFooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ class ReportFooter extends React.Component {
<SwipeableView onSwipeDown={Keyboard.dismiss}>
<OfflineWithFeedback
pendingAction={this.props.addWorkspaceRoomPendingAction}
style={this.props.isComposerFullSize && styles.chatItemFullComposeRow}
contentContainerStyle={this.props.isComposerFullSize && styles.flex1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is the comment staying at bottom of composer the expected behavior?

should it move to the top of the container when expanded? cc: @shawnborton

Screen.Recording.2022-10-06.at.4.34.32.AM.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good question - although my current Android app (staging, v1.2.11-2) does what's shown in this video - it has the comment floating at the bottom of the expanded text input, and I think it looks good that way

Copy link
Member

@rushatgabhane rushatgabhane Oct 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okayy cool

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this feels a bit strange personally. I would think the text should float to the top.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah ok! I think I'm happy either way, so if @shawnborton you think it should float to the top I'm down 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

>
<ReportActionCompose
onSubmit={this.props.onSubmitComment}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ const styles = {
}, 0),

textInputFullCompose: {
alignSelf: 'flex-end',
alignSelf: 'flex-start',
flex: 1,
maxHeight: '100%',
},
Expand Down