Make sure that archived reports are shown properly in the LHN and the search options #11725

tgolen · 2022-10-11T19:58:03Z

Fixed Issues

$ #11685
$ #11686

Tests

Testing that policy rooms show up properly

Set your view mode to #focus
Create a new workspace
Verify that there are no workspace rooms for that workspace shown in the LHN
Create several workspace rooms for that workspace (one pinned, one with a draft, one that is neither draft nor pinned but is your active chat)
Verify that all three user-created rooms are shown in the LHN
Verify that none of the default rooms are shown in the LHN (announce, admins, domain)
Verify that all three user-created rooms are shown in the report search options
Switch view mode to most recent
Verify that all three user-created rooms and all the default rooms are shown in the LHN
Verify that all three user-created rooms and all the default rooms are shown in the report search options

Testing that archived rooms show up properly

Set your view mode to #focus
Delete the workspace
Verify that all three user-created rooms are still shown in the LHN
Unpin the one chat, remove the draft on the other chat, and select the concierge chat
Verify that all three user-created rooms are no longer shown in the LHN
Verify that all three user-created rooms and all the default rooms are still shown in the report search options
Switch view mode to most recent
Verify that all three user-created rooms and all the default rooms are shown in the LHN

Testing that an invited user gets access to workspace chats

Invite a user to a new workspace
Login as that user
Verify they see the #announce room for that workspace

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Same as all the tests written in the test section

Verify that no errors appear in the JS console

Screenshots

Web screenhots

Mobile Web - Chrome screenhots

focus mode: ![image](https://user-images.githubusercontent.com/1228807/195188346-fa6f092a-4147-4821-ab44-6379fcbde999.png) ![image](https://user-images.githubusercontent.com/1228807/195188370-68de012c-d255-459c-b796-07cc44187de0.png)

most recent mode:

Mobile Web - Safari screenhots

focus mode: ![image](https://user-images.githubusercontent.com/1228807/195189359-8448dbb0-820f-44db-ac53-87f4d962b334.png) ![image](https://user-images.githubusercontent.com/1228807/195189379-76c3d99a-64a5-47b2-8ad4-675dcdb7fbea.png)

most recent mode:

Desktop screenhots

iOS screenhots

Focus mode: ![image](https://user-images.githubusercontent.com/1228807/195188755-b1410b4f-fac4-4029-913a-17c13dae0b4c.png) ![image](https://user-images.githubusercontent.com/1228807/195188792-7df74b6a-dd1a-4a42-9442-ad91f500190b.png)

most recent mode:

Android screenhots

focus mode:

most recent mode:

…r PR

github-actions · 2022-10-11T20:45:11Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

ctkochan22 · 2022-10-11T20:52:25Z

src/libs/OptionsListUtils.js

+        result.text = reportName;
+        result.searchText = getSearchText(report, reportName, personalDetailList, result.isChatRoom || result.isPolicyExpenseChat);
+        result.icons = ReportUtils.getIcons(report, personalDetails, policies, personalDetail.avatar);
+        result.subtitle = subtitle;


NAB, but I would this above line 307. 307-337 is a huge block that is dedicated to figuring out the alternateText.

Nitpicky i know, but seems strange to have all this after that.

Yeah, this actually broke some of the unit tests and some other code. I've gone and reverted this change. Good catch!

ctkochan22

Looks good!

ctkochan22 · 2022-10-11T22:24:51Z

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-11T22:29:41Z

@ctkochan22 looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

ctkochan22 · 2022-10-11T22:29:55Z

Checklists were all completed

Make sure that archived reports are shown properly in the LHN and the search options (cherry picked from commit 9090055)

…-11725 🍒 Cherry pick PR #11725 to staging 🍒

OSBotify · 2022-10-11T23:14:13Z

🚀 Deployed to production by @AndrewGable in version: 1.2.12-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-10-11T23:48:10Z

🚀 Cherry-picked to staging by @ctkochan22 in version: 1.2.12-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

…ering Make sure that archived reports are shown properly in the LHN and the search options

OSBotify · 2023-06-15T01:44:34Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

tgolen added 7 commits October 11, 2022 10:39

Write a basic test for archived chats when in default view mode

8462937

Add a full set of tests for archived chats

532f631

Add a test for actively viewed archived report

6cf9bf9

Simplify archived report logic

26465ba

Get all the tests passing for report logic combinations

509d3e3

Add comments for some sorting logic that was pointed out in an earlie…

ceff99e

…r PR

Remove commented out code and update jsdocs

4302bdc

tgolen self-assigned this Oct 11, 2022

Make some logic handle undefined reports better

a6b8939

tgolen marked this pull request as ready for review October 11, 2022 20:28

tgolen requested a review from a team as a code owner October 11, 2022 20:28

melvin-bot bot requested review from jasperhuangg and removed request for a team October 11, 2022 20:29

tgolen requested a review from ctkochan22 October 11, 2022 20:29

AndrewGable added the CP Staging label Oct 11, 2022

Allow for null reports when checking for archived reports

c6a8ec4

ctkochan22 reviewed Oct 11, 2022

View reviewed changes

tgolen added 2 commits October 11, 2022 15:04

Remove extra blank line

3c7fe24

Updating test to take into account new logic for archived reports

31b9684

ctkochan22 approved these changes Oct 11, 2022

View reviewed changes

ctkochan22 merged commit 9090055 into main Oct 11, 2022

ctkochan22 deleted the tgolen-archive-filtering branch October 11, 2022 22:29

melvin-bot bot added the Emergency label Oct 11, 2022

ctkochan22 removed the Emergency label Oct 11, 2022

OSBotify pushed a commit that referenced this pull request Oct 11, 2022

Merge pull request #11725 from Expensify/tgolen-archive-filtering

df6e040

Make sure that archived reports are shown properly in the LHN and the search options (cherry picked from commit 9090055)

OSBotify mentioned this pull request Oct 11, 2022

🍒 Cherry pick PR #11725 to staging 🍒 #11736

Merged

OSBotify added a commit that referenced this pull request Oct 11, 2022

Merge pull request #11736 from Expensify/OSBotify-cherry-pick-staging…

1fa0464

…-11725 🍒 Cherry pick PR #11725 to staging 🍒

OSBotify mentioned this pull request Oct 11, 2022

Deploy Checklist: New Expensify 2022-10-05 #11623

Closed

48 tasks

OSBotify mentioned this pull request Oct 12, 2022

Deploy Checklist: New Expensify 2022-10-11 #11741

Closed

48 tasks

smrutiparida pushed a commit to autosave-app/App that referenced this pull request Oct 13, 2022

Merge pull request Expensify#11725 from Expensify/tgolen-archive-filt…

f090cdf

…ering Make sure that archived reports are shown properly in the LHN and the search options

OSBotify mentioned this pull request Oct 14, 2022

Deploy Checklist: New Expensify 2022-10-14 #11873

Closed

53 tasks

johnmlee101 mentioned this pull request Oct 20, 2022

Web - LHN - Conversation that doesn't have a message doesn't disappear from LHN #11633

Closed

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure that archived reports are shown properly in the LHN and the search options #11725

Make sure that archived reports are shown properly in the LHN and the search options #11725

tgolen commented Oct 11, 2022 •

edited by ctkochan22

Loading

github-actions bot commented Oct 11, 2022

ctkochan22 Oct 11, 2022

tgolen Oct 11, 2022

ctkochan22 left a comment

ctkochan22 commented Oct 11, 2022

PR Reviewer Checklist

melvin-bot bot commented Oct 11, 2022

ctkochan22 commented Oct 11, 2022

OSBotify commented Oct 11, 2022

OSBotify commented Oct 11, 2022

OSBotify commented Jun 15, 2023

Make sure that archived reports are shown properly in the LHN and the search options #11725

Make sure that archived reports are shown properly in the LHN and the search options #11725

Conversation

tgolen commented Oct 11, 2022 • edited by ctkochan22 Loading

Fixed Issues

Tests

Testing that policy rooms show up properly

Testing that archived rooms show up properly

Testing that an invited user gets access to workspace chats

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

github-actions bot commented Oct 11, 2022

ctkochan22 Oct 11, 2022

Choose a reason for hiding this comment

tgolen Oct 11, 2022

Choose a reason for hiding this comment

ctkochan22 left a comment

Choose a reason for hiding this comment

ctkochan22 commented Oct 11, 2022

PR Reviewer Checklist

melvin-bot bot commented Oct 11, 2022

ctkochan22 commented Oct 11, 2022

OSBotify commented Oct 11, 2022

OSBotify commented Oct 11, 2022

OSBotify commented Jun 15, 2023

tgolen commented Oct 11, 2022 •

edited by ctkochan22

Loading