Add Workspace name label next to room name in the chats list #11799

bernhardoj · 2022-10-13T13:44:57Z

Details

Add Workspace name label next to room name in the chats list

Fixed Issues

$ #11543
PROPOSAL: #11543 (comment)

Tests

To test, you need to be at least in a workspace chat room.

Open chat list page
Verify every chat room named #admin or #announce
a. is not truncated
b. has a workspace name shown next to the chat room name
Verify long workspace name is truncated in one line

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

To test, you need to be at least in a workspace chat room.

Open chat list page
Verify every chat room named #admin or #announce
a. is not truncated
b. has a workspace name shown next to the chat room name
Verify long workspace name is truncated in one line

Verify that no errors appear in the JS console

Screenshots

Web

Compact	Not Compact

Mobile Web - Chrome

Compact	Not Compact

Mobile Web - Safari

Compact	Not Compact

Desktop

Compact	Not Compact

iOS

Compact	Not Compact

Android

Compact	Not Compact

github-actions · 2022-10-13T13:45:17Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

bernhardoj · 2022-10-13T14:12:49Z

I have read the CLA Document and I hereby sign the CLA

shawnborton · 2022-10-13T15:44:53Z

This is looking really good! Just a few design details:

The space between the room name and the pill should be just 4px
The horizontal padding inside of the pill should be 8px (it might be already, but just confirming)
The font size of the pill should be 11px, and we should already have a font size variable for this (micro? not sure what it's called)

bernhardoj · 2022-10-14T13:33:44Z

I have updated the code and the screenshots

shawnborton · 2022-10-14T14:59:00Z

For this screenshot here:

I don't think we want the #announce room to truncate unless it was truly wider than the total available horizontal width of that row. Let me know if that makes sense.

mananjadhav

Requested some smaller changes. @bernhardoj I would recommend add tests and screenshots for workspace name with ellipsis.

Also can we please add elaborate QA steps, this would involve, maybe identifying the #announce and #admin named chat?

src/components/LHNOptionsList/OptionRowLHN.js

mananjadhav · 2022-10-14T22:50:53Z

src/styles/themes/default.js

@@ -14,6 +14,7 @@ export default {
    border: colors.gray2,
    borderFocus: colors.blue,
    icon: colors.gray3,
+    iconLight: 'rgba(198, 201, 202, 0.5)',


Instead of doing this, we can stick to the existing colors.gray values and pass the style as opacity: 0.5

If we apply the opacity style to the text, it will affect the background color and the text itself. I was thinking that we could take the icon color and append the string with '80' (the hex will be #C6C9CA80), which is the hex code for the 50% opacity. So, it will look like this
StyleUtils.getBackgroundColorStyle(themeColors.icon + '80')
but I think it looks ugly, that's why I decided to add a new color.

If we still want to apply the opacity style, I think we need to change the TextPill component a bit by wrapping the text with View.

What do you think?

I am fine with wrapping the View around Text.

Okay, so it turns out that wrapping it with View and apply the opacity to the View also affects the Text. So, I think the only way is to apply the opacity to the backgroundColor.

Should I keep the iconLight color?

As far as I know, RN does not have such thing, but we can make our own implementation. I am thinking that maybe we could make a new function in StyleUtils.js let say getBackgroundColorWithOpacityStyle which takes the hex code as string and the opacity as number (0 to 1). Then, we will convert that hex to rgb numbers then return rgba(r, g, b, opacity). It will look like this:

function getBackgroundColorWithOpacityStyle(background, opacity) { const r = .... const g = .... const b = ..... return { backgroundColor: `rgba(${r}, ${g}, ${b}, ${opacity})` } }

What do you think?

I will lean on @mananjadhav and @marcochavezf to evaluate that, but I like the idea.

@bernhardoj Can we not just use rgb(r, g, b, 0.5) in the colors.js ?

Yes, we can remove the iconLight and use the new function above that I propose like this:
StyleUtils.getBackgroundColorWithOpacityStyle(themeColors.icon, 0.5).

My newest commit currently uses above approach. Let me know if there is any concern.

src/styles/styles.js

mananjadhav · 2022-10-14T22:54:48Z

src/components/TextPill.js

+
+const propTypes = {
+    /** Text to show */
+    children: PropTypes.string,


Can we rename this to something related to text say title? text. etc.?

children is generally used for nodes or React components and looks misleading here.

mananjadhav · 2022-10-14T22:55:38Z

src/components/TextPill.js

+};
+
+const defaultProps = {
+    children: '',


Instead of setting this empty, we should make the property mandatory

bernhardoj · 2022-10-15T15:45:36Z

For this screenshot here:

I don't think we want the #announce room to truncate unless it was truly wider than the total available horizontal width of that row. Let me know if that makes sense.

Fixed. I also put some newest screenshots with long workspace name and updated the test steps.

mananjadhav · 2022-10-15T17:09:04Z

src/components/LHNOptionsList/OptionRowLHN.js

+                                    {optionItem.isChatRoom && (
+                                        <TextPill
+                                            style={textPillStyle}
+                                            accessibilityLabel="Chat room name"


@marcochavezf @shawnborton Can one of you confirm if this is the correct accessibilityLabel ?

Deferring to @marcochavezf as I am unfamiliar with this one.

Ah good question, since this only be used for Workspace name atm let's change the value to Workspace name

mananjadhav · 2022-10-15T17:13:48Z

src/styles/styles.js

-        ...whiteSpace.noWrap,
-    },
-
-    optionDisplayNameCompact: {


Not sure I understand this change. Are we removing this style? This is used at two places (OptionRowLHN, and also OptionRow). I think removing this will break the styling in OptionRow.

Sorry, I missed that it is also being used at OptionRow component. I merge both styles to fix the #announce text got truncated on not compact mode. I will fix it later. Thanks for pointing it out!

mananjadhav · 2022-10-15T17:18:05Z

@bernhardoj Some more comments.

shawnborton · 2022-10-19T13:33:03Z

Screenshots look pretty good to me! @bernhardoj could you also try pinning one of these rooms that has a super long name, in both compact and normal mode, and sharing screenshots please? Thanks!

bernhardoj · 2022-10-19T16:09:28Z

@shawnborton I have updated the screenshots.

shawnborton · 2022-10-19T18:22:20Z

Awesome, screenshots look good to me! Thanks @bernhardoj

mananjadhav

Thanks for the changes and being patient with this @bernhardoj.

🎀 👀 🎀
C+ reviewed

mananjadhav · 2022-10-20T23:06:41Z

@marcochavezf @shawnborton Here's the checklist.

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcochavezf

Thank you guys looks mostly good to me! Just a comment related to displayNameStyle

marcochavezf · 2022-10-21T17:39:36Z

src/components/LHNOptionsList/OptionRowLHN.js

-    const displayNameStyle = StyleUtils.combineStyles(props.viewMode === CONST.OPTION_MODE.COMPACT
-        ? [styles.optionDisplayName, ...textUnreadStyle, styles.optionDisplayNameCompact, styles.mr2]
-        : [styles.optionDisplayName, ...textUnreadStyle], props.style);
+    const displayNameStyle = StyleUtils.combineStyles([styles.optionDisplayName, styles.optionDisplayNameCompact, ...textUnreadStyle], props.style);


Ah why are we merging styles.optionDisplayName and styles.optionDisplayNameCompact here? Originally we were only appending styles.optionDisplayNameCompact if props.viewMode === CONST.OPTION_MODE.COMPACT

When the viewMode is Compact, we put the latest chat text next to DisplayName and we append the style.optionDisplayNameCompact to make sure DisplayName will take the whole available width. Now, we have TextPill next to DisplayName, that's why I append it no matter what the viewMode is. If we don't do this, the DisplayName will get truncated like @shawnborton previously mentioned here.

For this screenshot here:

I don't think we want the #announce room to truncate unless it was truly wider than the total available horizontal width of that row. Let me know if that makes sense.

Any update on this?

Oh thanks for the explanation @bernhardoj, sorry for the delay here

…ensify#11543

marcochavezf

Thank you guys, LGTM

marcochavezf · 2022-10-26T15:49:51Z

The PR checklists were already filled out, but the GH actions are failing because the text of one checkbox changed. So I'm going to merge it to unblock this change.

melvin-bot · 2022-10-26T15:50:37Z

@marcochavezf looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcochavezf · 2022-10-26T15:51:03Z

@marcochavezf looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

#11799 (comment)

OSBotify · 2022-10-26T15:55:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-26T23:19:55Z

🚀 Deployed to staging by @marcochavezf in version: 1.2.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-28T02:24:37Z

🚀 Deployed to production by @chiragsalian in version: 1.2.20-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj requested a review from a team as a code owner October 13, 2022 13:44

melvin-bot bot requested review from mananjadhav and marcochavezf and removed request for a team October 13, 2022 13:45

bernhardoj mentioned this pull request Oct 13, 2022

[HOLD for payment 2022-11-04] [$250] Add Workspace name label next to room name in the chats list #11543

Closed

shawnborton self-requested a review October 13, 2022 15:41

shawnborton assigned shawnborton and bernhardoj and unassigned shawnborton Oct 13, 2022

mananjadhav suggested changes Oct 14, 2022

View reviewed changes

mananjadhav reviewed Oct 15, 2022

View reviewed changes

bernhardoj added 6 commits October 18, 2022 22:13

Add TextPill next to DisplayNames

e7ef127

simplify logic

e181e00

Changes styling a bit

445fc78

Change props

4444b2a

Fix styling

6360062

Fix styling

1731e74

bernhardoj force-pushed the feat/#11543 branch from cf21ec4 to 1731e74 Compare October 19, 2022 07:22

shawnborton previously approved these changes Oct 19, 2022

View reviewed changes

mananjadhav previously approved these changes Oct 20, 2022

View reviewed changes

marcochavezf reviewed Oct 21, 2022

View reviewed changes

bernhardoj dismissed stale reviews from mananjadhav and shawnborton via 57b6006 October 26, 2022 07:14

Merge with main branch

ca9bc6b

bernhardoj force-pushed the feat/#11543 branch from 57b6006 to ca9bc6b Compare October 26, 2022 13:38

Merge branch 'main' of https://github.com/Expensify/App into feat/Exp…

c43251d

…ensify#11543

marcochavezf approved these changes Oct 26, 2022

View reviewed changes

marcochavezf merged commit e263ffa into Expensify:main Oct 26, 2022

melvin-bot bot added the Emergency label Oct 26, 2022

marcochavezf removed the Emergency label Oct 26, 2022

OSBotify mentioned this pull request Oct 26, 2022

Deploy Checklist: New Expensify 2022-10-26 #12165

Closed

28 tasks

kbecciv mentioned this pull request Oct 27, 2022

[$250] LHN - Recently deleted workspace causes empty white placeholder in chat list #12206

Closed

shawnborton mentioned this pull request Jan 27, 2023

[HOLD for payment 2023-03-13] [$4000] LHN - Workspace badge is not fully visible/missing for some Room chats #14491

Closed

6 tasks

Add Workspace name label next to room name in the chats list #11799

Add Workspace name label next to room name in the chats list #11799

Conversation

bernhardoj commented Oct 13, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions bot commented Oct 13, 2022 • edited Loading

bernhardoj commented Oct 13, 2022

shawnborton commented Oct 13, 2022

bernhardoj commented Oct 14, 2022

shawnborton commented Oct 14, 2022

mananjadhav left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bernhardoj commented Oct 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav commented Oct 15, 2022

shawnborton commented Oct 19, 2022

bernhardoj commented Oct 19, 2022

shawnborton commented Oct 19, 2022

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented Oct 20, 2022 • edited Loading

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcochavezf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bernhardoj Oct 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcochavezf left a comment

Choose a reason for hiding this comment

marcochavezf commented Oct 26, 2022

melvin-bot bot commented Oct 26, 2022

marcochavezf commented Oct 26, 2022

OSBotify commented Oct 26, 2022

OSBotify commented Oct 26, 2022

OSBotify commented Oct 28, 2022

bernhardoj commented Oct 13, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading

mananjadhav left a comment •

edited

Loading

mananjadhav commented Oct 20, 2022 •

edited

Loading

bernhardoj Oct 22, 2022 •

edited

Loading