[HOLD] Refactor Workspace pages that use fetchFreePlanVerifiedBankAccount

[ctkochan22]

@Expensify/pullerbear @nkuoch @MariaHCD

Replace all the uses of BankAccounts.fetchFreePlanVerifiedBankAccount in WorkspacePageWithSections. After looking and discussing the approach here. It makes sense to just get rid of WorkspacePageWithSections as a whole, as its only point is to pretty much call fetchFreePlanVerifiedBankAccount

• WorkSpaceSettingsPage - link
• WorkspaceBillsPage - link
• WorkspaceCardPage - link
• WorkspaceInvoicesPage - link
• WorkspaceReimbursePage – Already covered in PolicyAPI refactor, but need to get rid of WorkspacePageWithSections
• WorkspaceTravelPage - link

Details

Fixed Issues

WorkspacePageWithSections case: https://github.com/Expensify/Expensify/issues/226858

Tests

• Verify that no errors appear in the JS console

QA Steps

We need to test first with an account with a workspace that no VBBA. And second with an account with workspaces that has a VBBA. So please perform these tests without one setup, then again with one setup.
(You can follow these instructions to setup a VBBA https://stackoverflow.com/c/expensify/questions/342 )

WorkSpaceSettingsPage:

• Navigate to Workspace-> Settings
  
• Verify that you can change the workspace name
• IF VBBA is setup, verify that currency picker is disabled
• IF VBBA is NOT setup, verify that currency picker is not disabled. And verify changing currency

WorkspaceBillsPage:

• Navigate to Workspace "Bills"
• IF VBBA is setup, verify that you see the "Hassle Free Bills" section
  
• IF VBBA is NOT setup, verify that currency picker is not disabled. And verify changing currency
  

WorkspaceCardPage:

• Navigate to Workspace "Issue Cards"
• IF VBBA is setup, verify that you see the "Hassle Free Bills" section
  
• IF VBBA is NOT setup, verify that you see a "Connect Bank Account" button and it works by sending you down VBBA setup flow
  

WorkspaceInvoicesPage:

• Navigate to Workspace "Send Invoices"
• IF VBBA is setup, verify that you see the "Money bank, in a flash!" section and no connect bank account button
  
• IF VBBA is NOT setup, verify that you see a "Connect Bank Account" button and the "Unlock online invoice collection" section
  

WorkspaceReimbursePage:

• Navigate to Workspace "Reimburse expenses"
• IF VBBA is setup, verify that you only see "Capture receipts" and "Track Distance" sections. Verify that you can change mileage rate and distance type (km vs mi)
  
• IF VBBA is NOT setup, verify that you see a "Connect Bank Account" button below the two sections and that you can change mileage rate and distance type (km vs mi)
  

WorkspaceTravelPage

• Navigate to Workspace "Book Travel"
• IF VBBA is setup, verify that you don't see a connect bank account button
  
• IF VBBA is NOT setup, verify that you see a "Connect Bank Account" button
  

PR Review Checklist

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[ctkochan22]

Don't review just yet. Need to clean up the some of the props and need to finish reimburse page

[JmillsExpensify]

Why is this issue on hold? Also when do you expect that conflicts will be resolved?

[ctkochan22]

Its no longer, but I'm going to close this for another PR. I removed the WorkPageWithSections and we decided that wasn't necessary

[ctkochan22]

PR coming up soon, as soon as I fix the ReimbursementAccountPage one

[JmillsExpensify]

Gotcha, thanks for closing the loop!

[ctkochan22]

Closing for #12586