Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderCell method as it's no longer needed and causes errors #12688

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Remove renderCell method as it's no longer needed and causes errors #12688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2efac49
Remove renderCell method as it's no longer needed and causes errors
yuwenmemon Nov 11, 2022
40f8927
Linter errors
yuwenmemon Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions src/pages/home/report/ReportActionsList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import {View, Animated} from 'react-native';
import {Animated} from 'react-native';
import InvertedFlatList from '../../../components/InvertedFlatList';
import withDrawerState, {withDrawerPropTypes} from '../../../components/withDrawerState';
import compose from '../../../libs/compose';
Expand Down Expand Up @@ -67,7 +67,6 @@ class ReportActionsList extends React.Component {
constructor(props) {
super(props);
this.renderItem = this.renderItem.bind(this);
this.renderCell = this.renderCell.bind(this);
this.keyExtractor = this.keyExtractor.bind(this);

this.state = {
Expand Down Expand Up @@ -146,32 +145,6 @@ class ReportActionsList extends React.Component {
);
}

/**
* This function overrides the CellRendererComponent (defaults to a plain View), giving each ReportActionItem a
* higher z-index than the one below it. This prevents issues where the ReportActionContextMenu overlapping between
* rows is hidden beneath other rows.
*
* @param {Object} cellData
* @param {Object} cellData.item - The ReportAction item in the FlatList.
* @param {Number} cellData.index – The index of the item in the FlatList
* @param {Object|Array} cellData.style – The default styles of the CellRendererComponent provided by the CellRenderer.
* @param {Object} props – All the other Props provided to the CellRendererComponent by default.
* @returns {JSX.Element}
*/
renderCell({
item,
index,
style,
...props
}) {
const cellStyle = [
style,
{zIndex: index},
];
// eslint-disable-next-line react/jsx-props-no-spreading
return <View style={cellStyle} {...props} />;
}

render() {
// Native mobile does not render updates flatlist the changes even though component did update called.
// To notify there something changes we can use extraData prop to flatlist
Expand Down