-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Remove unnecessary clientID from ReportActionsList keyExtractor #12727
Conversation
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Looks good but you gotta test and post screenshots for all platforms. I'll do the same and complete the checklist soon. |
@arosiclair finished providing screenshots on all platforms |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing mobile Safari I was able to consistently generate duplicate messages in the chat after sending a message while offline and reconnecting. The duplicate message generated a "duplicate key" error. This seems like a separate problem so I think this passes.
@roryabraham looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the |
All tests were passing |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @roryabraham in version: 1.2.30-0 🚀
|
🚀 Deployed to staging by @roryabraham in version: 1.2.30-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.30-0 🚀
|
Details
This is just a bit of cleanup related to deprecating sequence numbers. ReportActionID is random enough that we assume it's universally unique and therefore we'll have no collisions using it as a key in this list. The clientID will be gone soon and is no longer needed here.
Fixed Issues
$ n/a
Tests
QA Steps
No QA because (unless I'm mistaken) this console warning wouldn't show up on staging anyways.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Desktop
iOS
Android
![Screenshot_20221115-124147](https://user-images.githubusercontent.com/47436092/202021544-10e0d84a-387b-4919-87b2-10de566f78ce.png)