[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829

grgia · 2022-11-17T18:45:18Z

Details

Fixed Issues

$ #12822

Tests

Verify that no errors appear in the JS console
Verify all buttons are the correct style

QA Steps

Verify that no errors appear in the JS console
Verify all buttons have the correct text color

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

still works for dark switch

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions · 2022-11-17T18:54:23Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

melvin-bot · 2022-11-17T18:55:26Z

@sobitneupane @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2022-11-17T18:56:33Z

Whoops idk what just happened with puller bear, I didn't mean to remove

mountiny · 2022-11-17T18:58:27Z

Web - all the buttons seems to look great! Great quick fix @grgia 🎉

grgia · 2022-11-17T18:58:57Z

oh wait in the drop-down button it's black, is that expected?

mountiny · 2022-11-17T18:59:01Z

iOS also great!

mountiny

Tests well, except the dropdown button, noticed after this, lets address that too.

mountiny · 2022-11-17T18:59:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

grgia · 2022-11-17T19:01:22Z

@mountiny I'm gonna look into that dropdown button really quick

mountiny · 2022-11-17T19:03:23Z

@grgia I agree, noticed there are some black lines, lets fixed that first

grgia · 2022-11-17T19:06:32Z

@mountiny Should be Fixed!

mountiny

Nice yeah, all good now

mountiny · 2022-11-17T20:21:49Z

Merged this so the actions should pass now #12831

mountiny · 2022-11-17T21:07:11Z

Oh yeah that looks realted. I will have to head out soon so @aldo-expensify feel free to take over with merging :)

aldo-expensify · 2022-11-17T21:11:47Z

Oh yeah that looks realted. I will have to head out soon so @aldo-expensify feel free to take over with merging :)

Sure, no problem!

aldo-expensify · 2022-11-17T21:17:59Z

I have been testing random things, including offline behaviour and errors and I haven't spotted anything else beside the growl.

grgia · 2022-11-17T21:18:40Z

@aldo-expensify could you send a picture of the correct growl colors?

aldo-expensify · 2022-11-17T21:27:03Z

@aldo-expensify could you send a picture of the correct growl colors?

looking for it!

aldo-expensify · 2022-11-17T21:31:04Z

Does this help?

or do you need like the hex codes?

I got the growl from adding a paypal account in production

grgia · 2022-11-17T21:31:56Z

that's perfect! Latest commits should fix

aldo-expensify · 2022-11-17T21:35:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny

Nice!

mountiny · 2022-11-17T21:46:08Z

I think we can go ahead then! Thanks for fixing and reviewing this 🙌

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors (cherry picked from commit db2fea4)

…-12829 🍒 Cherry pick PR #12829 to staging 🍒

OSBotify · 2022-11-17T23:09:08Z

🚀 Cherry-picked to staging by @mountiny in version: 1.2.29-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-11-22T17:04:30Z

🚀 Deployed to production by @AndrewGable in version: 1.2.29-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:41:10Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:58:55Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix button text

1792930

grgia changed the title ~~Fix button text~~ Fix Success / Danger Button Text Color Nov 17, 2022

mountiny added the CP Staging label Nov 17, 2022

grgia self-assigned this Nov 17, 2022

grgia marked this pull request as ready for review November 17, 2022 18:54

grgia requested a review from a team as a code owner November 17, 2022 18:54

grgia requested review from mountiny and removed request for a team November 17, 2022 18:55

melvin-bot bot requested review from MonilBhavsar and sobitneupane November 17, 2022 18:55

grgia removed request for mountiny, MonilBhavsar and sobitneupane November 17, 2022 18:55

mountiny previously approved these changes Nov 17, 2022

View reviewed changes

Fix dropdown button line color

00bf1b9

grgia dismissed mountiny’s stale review via 00bf1b9 November 17, 2022 19:06

mountiny reviewed Nov 17, 2022

View reviewed changes

mountiny self-requested a review November 17, 2022 20:13

mountiny previously approved these changes Nov 17, 2022

View reviewed changes

Merge branch 'main' into georgia-fix-button

0820f8c

aldo-expensify self-requested a review November 17, 2022 21:11

Fix default inverse color

a147e4a

grgia dismissed mountiny’s stale review via a147e4a November 17, 2022 21:28

grgia changed the title ~~Fix Success / Danger Button Text Color~~ Fix Success / Danger Button Text Color, Fix Growl Colors Nov 17, 2022

mountiny changed the title ~~Fix Success / Danger Button Text Color, Fix Growl Colors~~ [CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors Nov 17, 2022

mountiny approved these changes Nov 17, 2022

View reviewed changes

mountiny merged commit db2fea4 into main Nov 17, 2022

mountiny deleted the georgia-fix-button branch November 17, 2022 21:46

OSBotify pushed a commit that referenced this pull request Nov 17, 2022

Merge pull request #12829 from Expensify/georgia-fix-button

327300c

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors (cherry picked from commit db2fea4)

OSBotify mentioned this pull request Nov 17, 2022

🍒 Cherry pick PR #12829 to staging 🍒 #12844

Merged

OSBotify added a commit that referenced this pull request Nov 17, 2022

Merge pull request #12844 from Expensify/OSBotify-cherry-pick-staging…

bf7c2ff

…-12829 🍒 Cherry pick PR #12829 to staging 🍒

OSBotify mentioned this pull request Nov 17, 2022

Deploy Checklist: New Expensify 2022-11-17 #12812

Closed

35 tasks

OSBotify mentioned this pull request Nov 22, 2022

Deploy Checklist: New Expensify 2022-11-22 #12934

Closed

40 tasks

grgia mentioned this pull request Nov 28, 2022

Text color appears black for all the buttons in the site - Reported by dhairyasenjaliya #12822

Closed

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829

grgia commented Nov 17, 2022 •

edited by mountiny

Loading

github-actions bot commented Nov 17, 2022

melvin-bot bot commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

mountiny left a comment •

edited

Loading

mountiny commented Nov 17, 2022 •

edited

Loading

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny left a comment

mountiny commented Nov 17, 2022

mountiny commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

grgia commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022 •

edited

Loading

grgia commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022 •

edited

Loading

mountiny left a comment

mountiny commented Nov 17, 2022

OSBotify commented Nov 17, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829

[CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829

Conversation

grgia commented Nov 17, 2022 • edited by mountiny Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions bot commented Nov 17, 2022

melvin-bot bot commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

mountiny left a comment • edited Loading

Choose a reason for hiding this comment

mountiny commented Nov 17, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

grgia commented Nov 17, 2022

mountiny commented Nov 17, 2022

grgia commented Nov 17, 2022

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Nov 17, 2022

mountiny commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

grgia commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022 • edited Loading

grgia commented Nov 17, 2022

aldo-expensify commented Nov 17, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Nov 17, 2022

OSBotify commented Nov 17, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

grgia commented Nov 17, 2022 •

edited by mountiny

Loading

mountiny left a comment •

edited

Loading

mountiny commented Nov 17, 2022 •

edited

Loading

aldo-expensify commented Nov 17, 2022 •

edited

Loading

aldo-expensify commented Nov 17, 2022 •

edited

Loading