fix "Upload photo" popup menu not hiding #13448

0xmiros · 2022-12-08T22:56:49Z

Details

Prevent parent's onclick event from firing when file input is clicked

Fixed Issues

$ #13435
PROPOSAL: #13435 (comment)

Tests

Login with any account
Go to Settings -> Profile
Click Profile Photo
Select Upload photo
Verify that popup menu with "Upload photo" hides and file select native modal shows

Verify that no errors appear in the JS console

Offline tests

Login with any account
Disable network
Go to Settings -> Profile
Click Profile Photo
Select Upload photo
Verify that popup menu with "Upload photo" hides and file select native modal shows

QA Steps

Login with any account
Go to Settings -> Profile
Click Profile Photo
Select Upload photo
Verify that popup menu with "Upload photo" hides and file select native modal shows

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

msafari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

melvin-bot · 2022-12-08T22:56:56Z

@marcaaron @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

francoisl

LGTM and thanks for the quick fix! Going to apply the CP Staging label since this is for a deploy blocker.

github-actions · 2022-12-08T23:56:02Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

marcaaron · 2022-12-09T04:49:18Z

src/components/AttachmentPicker/index.js

@@ -41,6 +41,9 @@ class AttachmentPicker extends React.Component {
                        // Cleanup after selecting a file to start from a fresh state
                        this.fileInput.value = null;
                    }}
+
+                    // Prevent parent's onclick event from firing


ideally this would say why and not just what - something like

We are stopping the event propagation because triggering the click() on the hidden input causes the event to unexpectedly bubble up to anything wrapping this component e.g. Pressable

That is better since someone will look at this later and have some idea about why the click event propagation needs to be stopped.

Thanks for your suggestion. updated

marcaaron · 2022-12-09T04:49:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2022-12-08_18-55-04.mp4

Mobile Web - Chrome

NOT ABLE TO TEST DUE to https://expensify.slack.com/archives/C049HHMV9SM/p1670538280256229

Mobile Web - Safari

NOT ABLE TO TEST DUE to https://expensify.slack.com/archives/C049HHMV9SM/p1670538280256229

Desktop

2022-12-08_18-56-32.mp4

iOS

Android

marcaaron

LGTM. I can't test locally on mWeb as there is some sort of crash happening. More context here.

I don't think that should block this PR from going to staging though so gonna merge it without those tests passing on my end.

marcaaron · 2022-12-09T05:12:47Z

Nice work with this one @0xmiroslav 🙇

fix "Upload photo" popup menu not hiding (cherry picked from commit 5948a0a)

…-13448 🍒 Cherry pick PR #13448 to staging 🍒

OSBotify · 2022-12-09T06:41:50Z

🚀 Cherry-picked to staging by @marcaaron in version: 1.2.37-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-15T01:39:16Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:57:01Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix "Upload photo" popup menu not hiding

b059f08

0xmiros requested a review from a team as a code owner December 8, 2022 22:56

melvin-bot bot requested review from marcaaron and thesahindia and removed request for a team December 8, 2022 22:56

francoisl previously approved these changes Dec 8, 2022

View reviewed changes

francoisl added the CP Staging label Dec 8, 2022

marcaaron removed the request for review from thesahindia December 9, 2022 04:45

marcaaron requested changes Dec 9, 2022

View reviewed changes

update comment for stopPropagation in file input

fee05c8

0xmiros dismissed francoisl’s stale review via fee05c8 December 9, 2022 04:54

marcaaron self-requested a review December 9, 2022 05:09

marcaaron approved these changes Dec 9, 2022

View reviewed changes

marcaaron merged commit 5948a0a into Expensify:main Dec 9, 2022

OSBotify pushed a commit that referenced this pull request Dec 9, 2022

Merge pull request #13448 from 0xmiroslav/issue-13435

734f331

fix "Upload photo" popup menu not hiding (cherry picked from commit 5948a0a)

OSBotify mentioned this pull request Dec 9, 2022

🍒 Cherry pick PR #13448 to staging 🍒 #13469

Merged

OSBotify added a commit that referenced this pull request Dec 9, 2022

Merge pull request #13469 from Expensify/OSBotify-cherry-pick-staging…

0cef7a1

…-13448 🍒 Cherry pick PR #13448 to staging 🍒

francoisl mentioned this pull request Dec 10, 2022

Deploy Checklist: New Expensify 2022-12-09 #13498

Closed

32 tasks

melvin-bot bot mentioned this pull request Dec 13, 2022

[HOLD for payment 2022-12-20] [$1000] Profile : Upload/Delete Photo popup not hiding #13435

Closed

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix "Upload photo" popup menu not hiding #13448

fix "Upload photo" popup menu not hiding #13448

0xmiros commented Dec 8, 2022

melvin-bot bot commented Dec 8, 2022

francoisl left a comment

github-actions bot commented Dec 8, 2022

marcaaron Dec 9, 2022 •

edited

Loading

0xmiros Dec 9, 2022

marcaaron commented Dec 9, 2022 •

edited

Loading

marcaaron left a comment

marcaaron commented Dec 9, 2022

OSBotify commented Dec 9, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

fix "Upload photo" popup menu not hiding #13448

fix "Upload photo" popup menu not hiding #13448

Conversation

0xmiros commented Dec 8, 2022

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 8, 2022

francoisl left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2022

marcaaron Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

0xmiros Dec 9, 2022

Choose a reason for hiding this comment

marcaaron commented Dec 9, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron commented Dec 9, 2022

OSBotify commented Dec 9, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

marcaaron Dec 9, 2022 •

edited

Loading

marcaaron commented Dec 9, 2022 •

edited

Loading