-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Refactor] ACHContractStep #13501
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
05d3bb2
Replace ReimbursementAccountForm with Form
grgia 4b089ce
Create ACHContractForm Onyx key and use it
grgia 797e578
Clean up inputs
grgia 780212a
Merge branch 'main' into georgia-ACH-form
grgia bee453f
Merge branch 'main' into georgia-ACH-form
grgia 6abfb7e
New commit
grgia cb0fff7
Merge branch 'georgia-ACH-form' of github.com:Expensify/App into geor…
grgia 292e3f3
Use corrext ONYX Form key, Use ReimbursementAccountUtils.getDefaultSt…
grgia 57c61d3
Use dynamic keys for IdentityForm
grgia b816f5b
Remove consoles, reformat data sent on submit
grgia 382b75a
Merge branch 'main' into georgia-ACH-form
grgia a379d39
Clean up code and remove unused ReimbursementAccountUtils
grgia 3ad4f46
Set to empty array if hasOtherBeneficialOwners is checked
grgia fbe7e15
Fix bug where 4 forms are submitted even if requester owns 25%
grgia a36e8a8
Fix bug where checking the beneifial owners check doesn't open an ide…
grgia 6a32616
Fix > 18 years old check
grgia 49098db
Update comment to be more descriptive
grgia 3f5c1cc
Fix long line
grgia ea35dc3
Merge branch 'main' into georgia-ACH-form
grgia b67bd24
Rename ownerID variable to ownerKey, add JSDocs and comments
grgia efed1c3
Use for loop for requiredFulfilled() calls
grgia 8d167d8
Use Str.guid to generate keys, add section to FORMS.md
grgia ccb589b
Fix param type, use variable name instead of value for clarity
grgia d5085c6
Replace '.' with '_' for key to not be confused with dot notation
grgia 45c97c1
Merge branch 'main' into georgia-ACH-form
grgia 853a4f9
pass props from forms
grgia d4a95a0
Log change
grgia d27dc93
Use default values / draft values for initial render of form
grgia aee6c38
Merge branch 'main' into georgia-ACH-form
grgia a63e322
fix JS console errors
grgia 5937ed9
Remove unused imports
grgia 0df7ec4
use props instead of this.props
grgia 27a6f27
Move proptype to single line
grgia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in the PR caused #14784 regression.
Title: Settings - Changed name is not saved under Display name page
Steps to reprodcue: