[No QA] Some console logs

[chiragsalian]

Details

Fixed Issues

None, some deploy logs to figure out the behavior issues.
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[francoisl]

Discussed in Slack, going to merge so we can test the deploy process

[melvin-bot]

@francoisl looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[chiragsalian]

No emergency. Just some console logs were added so review checklist was accidentally missed.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
TTI	793.619 ms → 809.355 ms (+15.735 ms, +2.0%)
nativeLaunch	9.563 ms → 9.867 ms (+0.304 ms, +3.2%)
regularAppStart	0.014 ms → 0.014 ms (+0.001 ms, +3.7%)
runJsBundle	180.968 ms → 180.433 ms (-0.534 ms, ±0.0%)

Show details

Name	Duration
TTI	Baseline Mean: 793.619 ms Stdev: 32.909 ms (4.1%) Runs: 735.2838429999538 740.882674000226 742.657305999659 747.4061509999447 756.6244630003348 761.6144969998859 767.765011000447 769.9613689999096 775.0584280001931 778.5301860002801 781.0235279998742 785.7018969999626 787.544780000113 792.0803640000522 795.5411790004 796.6610709996894 798.7333739995956 799.8032360002398 800.9633430000395 806.196066999808 808.396867999807 808.650231000036 811.4654609998688 812.1129060001113 825.2639849996194 825.3005079999566 827.590886999853 841.5222190003842 851.2607730003074 876.9815940000117 Current Mean: 809.355 ms Stdev: 34.946 ms (4.3%) Runs: 752.7530709998682 754.7935960004106 760.2647169996053 774.2073529995978 775.6805400000885 778.9454880002886 779.0168160004541 779.8018669998273 783.3319309996441 788.6349700000137 789.8149990001693 790.2549130003899 794.2916050003842 796.3380859997123 798.4878900004551 798.7546800002456 801.1507590003312 812.4964560000226 814.8081719996408 820.7658270001411 821.6284630000591 828.0918230004609 834.2423040000722 839.113188999705 840.8340060003102 847.7305849995464 850.9259360004216 861.2440680004656 869.3952700002119 870.7390780001879 881.4556309999898
nativeLaunch	Baseline Mean: 9.563 ms Stdev: 1.657 ms (17.3%) Runs: 8 8 8 8 8 8 8 8 8 8 8 8 9 9 9 9 9 10 10 10 10 10 10 10 11 11 11 11 12 12 12 15 Current Mean: 9.867 ms Stdev: 1.910 ms (19.4%) Runs: 7 8 8 8 8 8 8 8 8 9 9 9 9 9 9 10 10 10 10 10 11 11 11 11 11 12 12 13 14 15
regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (4.0%) Runs: 0.012858000118285418 0.0129399998113513 0.013021000195294619 0.013061999343335629 0.01314299926161766 0.013265000656247139 0.013386999256908894 0.013386999722570181 0.013590999878942966 0.013630999717861414 0.013712999876588583 0.0138349998742342 0.013875000178813934 0.013875999953597784 0.013956000097095966 0.013956999406218529 0.01399700017645955 0.014078999869525433 0.014079000800848007 0.014119999948889017 0.014159999787807465 0.014241000637412071 0.014281999785453081 0.014282000251114368 0.014322999864816666 0.014322999864816666 0.014323000330477953 0.014403999783098698 0.014527000486850739 0.014689999632537365 0.014770000241696835 0.015096000395715237 Current Mean: 0.014 ms Stdev: 0.001 ms (6.0%) Runs: 0.012858000583946705 0.012938999570906162 0.013019999489188194 0.013427999801933765 0.013427999801933765 0.013508999720215797 0.013834000565111637 0.0138349998742342 0.013875000178813934 0.013915999792516232 0.014038000255823135 0.014079000800848007 0.014119000174105167 0.014322999864816666 0.01432300079613924 0.01444500032812357 0.014485999941825867 0.014568000100553036 0.014648000709712505 0.014649000018835068 0.014851000159978867 0.014973999932408333 0.014973999932408333 0.015096000395715237 0.015177999623119831 0.015298999845981598 0.015300000086426735 0.015542999841272831 0.015666000545024872 0.01607200037688017 0.016154000535607338
runJsBundle	Baseline Mean: 180.968 ms Stdev: 17.708 ms (9.8%) Runs: 157 159 160 163 165 166 167 168 168 169 170 171 171 172 176 178 179 179 180 181 183 188 190 190 194 200 202 206 213 220 225 Current Mean: 180.433 ms Stdev: 11.488 ms (6.4%) Runs: 152 160 168 168 169 170 171 175 175 175 176 176 177 178 179 182 182 182 186 187 187 187 187 190 191 192 193 194 194 210

[OSBotify]

🚀 Deployed to staging by @francoisl in version: 1.2.41-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @francoisl in version: 1.2.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.2.41-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅